Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 1049983003: [Fetch] Body consume function should not set bodyUsed flag. (Closed)

Created:
5 years, 8 months ago by yhirano
Modified:
5 years, 8 months ago
Reviewers:
jsbell, horo
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@stream-clone
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[Fetch] Body consume function should not set bodyUsed flag. As discussed at [1], functions such as Response.text() should not set 'body passed' flag and the body will be accessible again when the consumption is done. 1: https://github.com/slightlyoff/ServiceWorker/issues/452 BUG=472931 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193054

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : Fix assertion errors. #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -68 lines) Patch
M LayoutTests/http/tests/cachestorage/script-tests/cache-add.js View 1 2 3 4 5 1 chunk +2 lines, -6 lines 0 comments Download
M LayoutTests/http/tests/cachestorage/script-tests/cache-put.js View 1 2 3 4 5 1 chunk +4 lines, -7 lines 0 comments Download
M LayoutTests/http/tests/fetch/script-tests/request.js View 1 chunk +10 lines, -8 lines 0 comments Download
M LayoutTests/http/tests/fetch/script-tests/response.js View 1 chunk +15 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/fetch/script-tests/response-content.js View 1 1 chunk +26 lines, -22 lines 0 comments Download
M Source/modules/fetch/Body.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/modules/fetch/Body.cpp View 1 2 3 4 7 chunks +74 lines, -21 lines 0 comments Download
M Source/modules/fetch/Response.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/Cache.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/RespondWithObserver.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 30 (15 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1049983003/1
5 years, 8 months ago (2015-04-01 05:00:52 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/40397) mac_blink_rel on tryserver.blink (JOB_FAILED, ...
5 years, 8 months ago (2015-04-01 05:05:36 UTC) #6
yhirano
This CL depends on https://codereview.chromium.org/1053503002/.
5 years, 8 months ago (2015-04-01 05:11:10 UTC) #8
horo
lgtm with nit https://codereview.chromium.org/1049983003/diff/20001/Source/modules/fetch/Body.cpp File Source/modules/fetch/Body.cpp (right): https://codereview.chromium.org/1049983003/diff/20001/Source/modules/fetch/Body.cpp#newcode316 Source/modules/fetch/Body.cpp:316: } else { nit: Why don't ...
5 years, 8 months ago (2015-04-01 12:04:54 UTC) #9
yhirano
https://codereview.chromium.org/1049983003/diff/20001/Source/modules/fetch/Body.cpp File Source/modules/fetch/Body.cpp (right): https://codereview.chromium.org/1049983003/diff/20001/Source/modules/fetch/Body.cpp#newcode316 Source/modules/fetch/Body.cpp:316: } else { On 2015/04/01 12:04:54, horo wrote: > ...
5 years, 8 months ago (2015-04-01 12:11:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1049983003/40001
5 years, 8 months ago (2015-04-01 12:12:24 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1049983003/80001
5 years, 8 months ago (2015-04-02 02:00:31 UTC) #17
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1049983003/100001
5 years, 8 months ago (2015-04-02 03:46:04 UTC) #20
yhirano
I fixed cache tests. jsbell@, are you OK with this change?
5 years, 8 months ago (2015-04-02 03:46:59 UTC) #22
commit-bot: I haz the power
This issue passed the CQ dry run.
5 years, 8 months ago (2015-04-02 05:16:56 UTC) #24
jsbell
On 2015/04/02 03:46:59, yhirano wrote: > I fixed cache tests. jsbell@, are you OK with ...
5 years, 8 months ago (2015-04-02 16:58:30 UTC) #25
jsbell
On 2015/04/02 16:58:30, jsbell wrote: > On 2015/04/02 03:46:59, yhirano wrote: > > I fixed ...
5 years, 8 months ago (2015-04-02 16:58:42 UTC) #26
yhirano
thanks!
5 years, 8 months ago (2015-04-02 23:51:33 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1049983003/100001
5 years, 8 months ago (2015-04-02 23:54:12 UTC) #29
commit-bot: I haz the power
5 years, 8 months ago (2015-04-02 23:55:58 UTC) #30
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193054

Powered by Google App Engine
This is Rietveld 408576698