Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 1049523003: Re-write duplicated assertions (Closed)

Created:
5 years, 8 months ago by mike3
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Re-write duplicated assertions The modified assertions targeted the property descriptor for the template object's first "cooked" value. The code immediately preceeding these statements asserts these values. Update the assertions to instead target the property descriptor for the template object's first "raw" value (which are otherwise untested). BUG= Committed: https://crrev.com/3badfdcd50d58b94d7a9adee72a671d99051e22f Cr-Commit-Position: refs/heads/master@{#27566}

Patch Set 1 #

Patch Set 2 : Updated to include necessary change to AUTHORS file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M AUTHORS View 1 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/es6/templates.js View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
arv (Not doing code reviews)
LGTM
5 years, 8 months ago (2015-03-31 21:56:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1049523003/1
5 years, 8 months ago (2015-03-31 23:15:16 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/1672)
5 years, 8 months ago (2015-03-31 23:27:04 UTC) #6
arv (Not doing code reviews)
On 2015/03/31 23:27:04, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
5 years, 8 months ago (2015-03-31 23:33:10 UTC) #7
mike3
I've uploaded a new patch that includes the necessary changes to the AUTHORS file. I'll ...
5 years, 8 months ago (2015-04-01 00:05:46 UTC) #8
arv (Not doing code reviews)
LGTM
5 years, 8 months ago (2015-04-01 14:37:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1049523003/20001
5 years, 8 months ago (2015-04-01 14:37:36 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-01 15:13:22 UTC) #12
commit-bot: I haz the power
5 years, 8 months ago (2015-04-01 15:13:32 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3badfdcd50d58b94d7a9adee72a671d99051e22f
Cr-Commit-Position: refs/heads/master@{#27566}

Powered by Google App Engine
This is Rietveld 408576698