Use the ICU syntax message for plural formatting

Use the ICU syntax message for plural formatting.

Chrome trail-blazed using ICU plural format support in 2008~9. Due to the lack of support for plural in our translation pipeline, Chrome decided to use 6 strings (for each plural category) for each logical string and builds ICU's plural message pattern at run-time.

Now that we can utilize the translation pipeline that supports ICU syntax directly (as are Android and other Google products), we'd better switch to directly using ICU syntax.

That way, adding a new string requiring a plural formatting is made much simpler. And if necessary, we can add a gender support easily.

BUG=471827
TEST=ui_base_unit_tests --gtest_filter=*Format*

Committed: https://crrev.com/3a6c36bbd58de11de968cea7c271d5516d320dce
Cr-Commit-Position: refs/heads/master@{#324517}

[jungshik at Google, 2015-04-02 22:35:33]

jshin@chromium.org changed reviewers:
+ tnagel@chromium.org, tony@chromium.org

[jungshik at Google, 2015-04-03 06:48:37]

jshin@chromium.org changed reviewers:
+ sammc@chromium.org

[jungshik at Google, 2015-04-03 06:48:38]

Can you take a look? 

In the latest CL, I decided to follow a convention followed by virtually all
other Google projects using 'ICU Syntax' by dropping 'place holder markup'
around '#' because I'm worried that having a place holder in place of '#' is
likely to confuse translators who are used to seeing 'bare' # in ICU Syntax
plural messages.  That's also recommended by an engineer working on the
translation pipeline at Google. 

I confirmed that 'grd -> xmb' part works fine. Even though I didn't actually see
what comes out of the translation pipeline ( xmb -> trans pipeline -> xtb)
because I couldn't make an actual translation request, I'm pretty sure it should
work because "xmb -> trans. pipeline -> xtb" part is independent of the input
format (in our case, grd) and a number of other projects have used this process.


The only worry I have is whether 'xtb -> pak' (done by grit during Chrome's
build)  time) will 'mangle' curly braces or '#' because they have some special
meaning.  

I will modify one of existing xtb files to add those characters to a string and
see how they come out. I'm pretty sure that they'll remain intact. 

BTW, "[ICU Syntax]" in the message description is not required any more because
our translation pipeline will automatically recognize strings in ICU syntax and
present the UI suitable for ICU Syntax to translators/linguists. Nonetheless, I
keep it (just in case).

[tony, 2015-04-03 20:30:51]

This looks much simpler!  xtb -> pak should be fine.  {} and # don't have any
special meaning.

LGTM, but note that I haven't been on the Chromium team for over 18 months.  I
have been using soy templates and the simpler formatting for numbers is really
nice.

[jungshik at Google, 2015-04-03 22:51:59]

On 2015/04/03 20:30:51, tony wrote:
> This looks much simpler!  xtb -> pak should be fine.  {} and # don't have any
> special meaning.
> 
> LGTM, but note that I haven't been on the Chromium team for over 18 months.  I
> have been using soy templates and the simpler formatting for numbers is really
> nice.

Thanks a lot, Tony, for reviewing and confirming that {} and # would pass
through in xtb -> pak !!
 I noticed that you haven't been on the Cr team, but you're the still the
authority here :-).

[jungshik at Google, 2015-04-06 18:43:19]

Thiemo and Sam, do you have any comment?

[Sam McNally, 2015-04-07 01:30:58]

Thanks for cleaning this up! LGTM with one question.

https://codereview.chromium.org/1049513002/diff/160001/ui/strings/ui_strings.grd
File ui/strings/ui_strings.grd (right):

https://codereview.chromium.org/1049513002/diff/160001/ui/strings/ui_strings....
ui/strings/ui_strings.grd:222: desc="[ICU Syntax]">
Do these need a description of what the string is for?

[jungshik at Google, 2015-04-08 23:08:52]

jshin@chromium.org changed reviewers:
+ finnur@chromium.org, pkasting@chromium.org

[jungshik at Google, 2015-04-08 23:08:54]

finnur@chromium.org: Please review changes in chrome/browser/extension

pkasting@chromium.org: Please review changes in chrome/browser/ui.

[jungshik at Google, 2015-04-08 23:09:54]

On 2015/04/07 01:30:58, Sam McNally wrote:
> Thanks for cleaning this up! LGTM with one question.
> 
>
https://codereview.chromium.org/1049513002/diff/160001/ui/strings/ui_strings.grd
> File ui/strings/ui_strings.grd (right):
> 
>
https://codereview.chromium.org/1049513002/diff/160001/ui/strings/ui_strings....
> ui/strings/ui_strings.grd:222: desc="[ICU Syntax]">
> Do these need a description of what the string is for?

Thanks. Yeah, they're kinda border-line. Anyway, I added descriptions for them.

[Peter Kasting, 2015-04-08 23:29:59]

LGTM, awesome

[Finnur, 2015-04-09 09:16:21]

On 2015/04/08 23:29:59, Peter Kasting wrote:
> LGTM, awesome

Second that. Awesome! LGTM.

[jungshik at Google, 2015-04-09 17:31:27]

The CQ bit was checked by jshin@chromium.org

[jungshik at Google, 2015-04-09 17:31:28]

The patchset sent to the CQ was uploaded after l-g-t-m from tony@chromium.org,
sammc@chromium.org, pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/1049513002/#ps220001
(title: "more lint fixes")

[commit-bot: I haz the power, 2015-04-09 17:31:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1049513002/220001

[commit-bot: I haz the power, 2015-04-09 17:41:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-09 17:41:19]

Try jobs failed on following builders:
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[jungshik at Google, 2015-04-09 19:55:23]

The CQ bit was checked by jshin@chromium.org

[jungshik at Google, 2015-04-09 19:55:24]

The patchset sent to the CQ was uploaded after l-g-t-m from tony@chromium.org,
pkasting@chromium.org, sammc@chromium.org, finnur@chromium.org
Link to the patchset: https://codereview.chromium.org/1049513002/#ps240001
(title: "ios whitelist update")

[commit-bot: I haz the power, 2015-04-09 19:55:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1049513002/240001

[commit-bot: I haz the power, 2015-04-09 21:58:22]

Committed patchset #13 (id:240001)

[commit-bot: I haz the power, 2015-04-09 21:59:15]

Patchset 13 (id:??) landed as
https://crrev.com/3a6c36bbd58de11de968cea7c271d5516d320dce
Cr-Commit-Position: refs/heads/master@{#324517}

[Avi (use Gerrit), 2015-04-28 00:37:11]

On 2015/04/09 21:59:15, I haz the power (commit-bot) wrote:
> Patchset 13 (id:??) landed as
> https://crrev.com/3a6c36bbd58de11de968cea7c271d5516d320dce
> Cr-Commit-Position: refs/heads/master@{#324517}

Holy crap! Yay!!!!!!