content/browser/web_contents/web_contents_impl.cc - Issue 1048963002: Fix incorrect creation of duplicate navigation entries for repeated page load failures.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 1048963002: Fix incorrect creation of duplicate navigation entries for repeated page load failures. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@committype3

Patch Set: with more comment Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/web_contents/web_contents_impl.cc

diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc

index 24122cdae08c31f7a61e67ece68cf874cca9c3af..a37400ce0496d3d0259aac9aaa60a6c4e0ba6b28 100644

--- a/content/browser/web_contents/web_contents_impl.cc

+++ b/content/browser/web_contents/web_contents_impl.cc

@@ -3906,7 +3906,7 @@ void WebContentsImpl::DidAccessInitialDocument() {

// to let the user edit it and try again. Clear it now that content might

// show up underneath it.

if (!IsLoading() && controller_.GetPendingEntry())

- controller_.DiscardPendingEntry();

+ controller_.DiscardPendingEntry(false);

// Update the URL display.

NotifyNavigationStateChanged(INVALIDATE_TYPE_URL);

« no previous file with comments | « content/browser/frame_host/navigator_impl.cc ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »