content/browser/frame_host/navigator_impl.cc - Issue 1048963002: Fix incorrect creation of duplicate navigation entries for repeated page load failures.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigator_impl.cc

Issue 1048963002: Fix incorrect creation of duplicate navigation entries for repeated page load failures. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@committype3

Patch Set: with more comment Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/navigation_controller_impl_browsertest.cc ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/navigator_impl.cc

diff --git a/content/browser/frame_host/navigator_impl.cc b/content/browser/frame_host/navigator_impl.cc

index d6ac418ebe47f48e932a2586a535d63b922cdaf3..527eda7d6c833688a45331a6b1d1c5ee40d9771b 100644

--- a/content/browser/frame_host/navigator_impl.cc

+++ b/content/browser/frame_host/navigator_impl.cc

@@ -227,7 +227,7 @@ void NavigatorImpl::DidFailProvisionalLoadWithError(

delegate_->ShouldPreserveAbortedURLs();

if (controller_->GetPendingEntry() != controller_->GetVisibleEntry() ||

!should_preserve_entry) {

- controller_->DiscardPendingEntry();

+ controller_->DiscardPendingEntry(true);

// Also force the UI to refresh.

controller_->delegate()->NotifyNavigationStateChanged(INVALIDATE_TYPE_URL);