Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 1048873002: fix arguments keyword used in our helper method (Closed)

Created:
5 years, 8 months ago by Jennifer Messerly
Modified:
5 years, 8 months ago
Reviewers:
Jacob
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M lib/runtime/dart/core.js View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/codegen/js_codegen.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M lib/src/codegen/js_names.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/server_mode/html_input.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Jennifer Messerly
5 years, 8 months ago (2015-03-30 17:40:20 UTC) #2
Jacob
lgtm!
5 years, 8 months ago (2015-03-30 17:45:59 UTC) #3
Jennifer Messerly
5 years, 8 months ago (2015-03-30 17:46:17 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
64d75ecae1e88f3623a9d6caf947e83f91b3cd69 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698