lib/src/codegen/js_names.dart - Issue 1048873002: fix arguments keyword used in our helper method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/src/codegen/js_names.dart

Issue 1048873002: fix arguments keyword used in our helper method (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/src/codegen/js_names.dart

diff --git a/lib/src/codegen/js_names.dart b/lib/src/codegen/js_names.dart

index 561f954f87350c35d9ee10d978d500008f7024d2..56f67b7df4bcbd223ded5911ee9f4a3d021765f6 100644

--- a/lib/src/codegen/js_names.dart

+++ b/lib/src/codegen/js_names.dart

@@ -40,7 +40,7 @@ class JSNamer extends LocalNamer {

var name = node.name;

if (node is JSTemporary) {

return _rename(name, valid: true);

- } else if (invalidJSVariableName(name)) {

+ } else if (node.allowRename && invalidJSVariableName(name)) {

return _rename(name, valid: false);

}

return name;

« no previous file with comments | « lib/src/codegen/js_codegen.dart ('k') | test/codegen/expect/server_mode/html_input.html » ('j') | no next file with comments »