Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Unified Diff: chrome/browser/ui/cocoa/spinner_view.h

Issue 1048733004: Add a Material Design Circular Activity Indicator (Spinner) view for Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix nits and rename class to SpinnerView. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/spinner_view.mm » ('j') | chrome/browser/ui/cocoa/spinner_view.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/spinner_view.h
diff --git a/chrome/browser/ui/cocoa/spinner_view.h b/chrome/browser/ui/cocoa/spinner_view.h
new file mode 100644
index 0000000000000000000000000000000000000000..44a003cd8775117d0160d582213d7d730c0a3762
--- /dev/null
+++ b/chrome/browser/ui/cocoa/spinner_view.h
@@ -0,0 +1,22 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_COCOA_SPINNER_VIEW_H_
+#define CHROME_BROWSER_UI_COCOA_SPINNER_VIEW_H_
+
+#import <Cocoa/Cocoa.h>
+
+#include "base/mac/scoped_nsobject.h"
Robert Sesek 2015/04/01 16:25:01 #import over #include
shrike 2015/04/01 20:55:54 Done.
+
+@class CAAnimationGroup;
Robert Sesek 2015/04/01 16:25:01 These forward declares are unnecessary.
shrike 2015/04/01 20:55:54 Remnants of a previous change. Done.
+@class CAShapeLayer;
+
+@interface SpinnerView : NSView {
+ @private
Robert Sesek 2015/04/01 16:25:01 nit: only indent @private 1 space http://google-s
shrike 2015/04/01 20:55:54 OK.
+ bool is_animating_;
Robert Sesek 2015/04/01 16:25:01 naming: isAnimating_ The rule is if writing an Ob
shrike 2015/04/01 20:55:53 OK.
+}
+
+@end
+
+#endif // CHROME_BROWSER_UI_COCOA_SPINNER_VIEW_H_
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/spinner_view.mm » ('j') | chrome/browser/ui/cocoa/spinner_view.mm » ('J')

Powered by Google App Engine
This is Rietveld 408576698