chrome/browser/ui/cocoa/spinner_view.h - Issue 1048733004: Add a Material Design Circular Activity Indicator (Spinner) view for Mac.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/cocoa/spinner_view.h

Issue 1048733004: Add a Material Design Circular Activity Indicator (Spinner) view for Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix nits and rename class to SpinnerView. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_UI_COCOA_SPINNER_VIEW_H_

	6 #define CHROME_BROWSER_UI_COCOA_SPINNER_VIEW_H_

	7

	8 #import <Cocoa/Cocoa.h>

	9

	10 #include "base/mac/scoped_nsobject.h"
	Robert Sesek 2015/04/01 16:25:01 #import over #include #import over #include shrike 2015/04/01 20:55:54 Done. Show quoted text On 2015/04/01 16:25:01, Robert Sesek wrote: > #import over #include Done.
	11

	12 @class CAAnimationGroup;
	Robert Sesek 2015/04/01 16:25:01 These forward declares are unnecessary. These forward declares are unnecessary. shrike 2015/04/01 20:55:54 Remnants of a previous change. Done. Show quoted text On 2015/04/01 16:25:01, Robert Sesek wrote: > These forward declares are unnecessary. Remnants of a previous change. Done.
	13 @class CAShapeLayer;

	14

	15 @interface SpinnerView : NSView {

	16 @private
	Robert Sesek 2015/04/01 16:25:01 nit: only indent @private 1 space http://google-s nit: only indent @private 1 space http://google-styleguide.googlecode.com/svn/trunk/objcguide.xml?showone=Insta... shrike 2015/04/01 20:55:54 OK. Show quoted text On 2015/04/01 16:25:01, Robert Sesek wrote: > nit: only indent @private 1 space > > http://google-styleguide.googlecode.com/svn/trunk/objcguide.xml?showone=Insta... OK.
	17 bool is_animating_;
	Robert Sesek 2015/04/01 16:25:01 naming: isAnimating_ The rule is if writing an Ob naming: isAnimating_ The rule is if writing an ObjC class, use camelCase, otherwise use under_scores. shrike 2015/04/01 20:55:53 OK. Show quoted text On 2015/04/01 16:25:01, Robert Sesek wrote: > naming: isAnimating_ > > The rule is if writing an ObjC class, use camelCase, otherwise use under_scores. OK.
	18 }

	19

	20 @end

	21

	22 #endif // CHROME_BROWSER_UI_COCOA_SPINNER_VIEW_H_

OLD	NEW

« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/spinner_view.mm » ('j') | chrome/browser/ui/cocoa/spinner_view.mm » ('J')