Add a MultiProcessTest::SpawnChildWithOptions().

Add a MultiProcessTest::SpawnChildWithOptions().

Replace SpawnChildImpl() with SpawnChildWithOptions(). Leave the
now-superfluous POSIX-only SpawnChild() that takes a
FileHandleMappingVector for now.

R=brettw@chromium.org, brettw

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239258

[viettrungluu, 2013-12-06 19:22:29]

You can review this, even if I don't yet know if it compiles on non-Linux.

[brettw, 2013-12-06 20:40:05]

lgtm

https://codereview.chromium.org/104803007/diff/1/base/test/multiprocess_test_...
File base/test/multiprocess_test_android.cc (right):

https://codereview.chromium.org/104803007/diff/1/base/test/multiprocess_test_...
base/test/multiprocess_test_android.cc:24: // TODO(vtl): The FD-remapping done
below is wrong (e.g., for fd1 -> fd2, fd2
Can you clarify this a bit? Like "...done below is wrong in the presence of
cycles" or something.

[viettrungluu, 2013-12-06 21:23:09]

Thanks.

https://codereview.chromium.org/104803007/diff/1/base/test/multiprocess_test_...
File base/test/multiprocess_test_android.cc (right):

https://codereview.chromium.org/104803007/diff/1/base/test/multiprocess_test_...
base/test/multiprocess_test_android.cc:24: // TODO(vtl): The FD-remapping done
below is wrong (e.g., for fd1 -> fd2, fd2
On 2013/12/06 20:40:05, brettw wrote:
> Can you clarify this a bit? Like "...done below is wrong in the presence of
> cycles" or something.

Done.

[viettrungluu, 2013-12-06 21:23:45]

Committed patchset #2 manually as r239258 (presubmit successful).