| Index: base/test/multiprocess_test.h
|
| diff --git a/base/test/multiprocess_test.h b/base/test/multiprocess_test.h
|
| index 3bbb7396c0dc56196671d03af4854046c0ace3e6..4bf70ab383d8d2665508843ae5453a40ac41f4cb 100644
|
| --- a/base/test/multiprocess_test.h
|
| +++ b/base/test/multiprocess_test.h
|
| @@ -56,10 +56,16 @@ class MultiProcessTest : public PlatformTest {
|
| // Returns the handle to the child, or NULL on failure
|
| ProcessHandle SpawnChild(const std::string& procname, bool debug_on_start);
|
|
|
| + // Run a child process using the given launch options.
|
| + //
|
| + // Note: On Windows, you probably want to set |options.start_hidden|.
|
| + ProcessHandle SpawnChildWithOptions(const std::string& procname,
|
| + const LaunchOptions& options,
|
| + bool debug_on_start);
|
| +
|
| #if defined(OS_POSIX)
|
| - // TODO(evan): see if we can delete this via more refactoring.
|
| - // SpawnChild() should just take a base::LaunchOptions so that we don't
|
| - // need multiple versions of it.
|
| + // TODO(vtl): Remove this in favor of |SpawnChildWithOptions()|. Probably keep
|
| + // the no-options |SpawnChild()| around for ease-of-use.
|
| ProcessHandle SpawnChild(const std::string& procname,
|
| const FileHandleMappingVector& fds_to_map,
|
| bool debug_on_start);
|
| @@ -70,13 +76,6 @@ class MultiProcessTest : public PlatformTest {
|
| bool debug_on_start);
|
|
|
| private:
|
| - // Shared implementation of SpawnChild.
|
| - // TODO: |fds_to_map| is unused on Windows; see above TODO about
|
| - // further refactoring.
|
| - ProcessHandle SpawnChildImpl(const std::string& procname,
|
| - const FileHandleMappingVector& fds_to_map,
|
| - bool debug_on_start);
|
| -
|
| DISALLOW_COPY_AND_ASSIGN(MultiProcessTest);
|
| };
|
|
|
|
|