Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 104803006: Revert of Re-enable GN in the GYP build. (Closed)

Created:
7 years ago by Pat Meenan
Modified:
7 years ago
Reviewers:
pmeenan, Nico, brettw
CC:
chromium-reviews
Visibility:
Public.

Description

Revert of https://codereview.chromium.org/102243005/ Reason for revert: Breaking the Windows perf build bots - https://code.google.com/p/chromium/issues/detail?id=326146 TBR=thakis@chromium.org,brettw@chromium.org NOTREECHECKS=true NOTRY=true

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -13 lines) Patch
M build/gyp_chromium View 4 chunks +5 lines, -13 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
Pat Meenan
Created Revert of Re-enable GN in the GYP build.
7 years ago (2013-12-05 13:44:01 UTC) #1
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years ago (2013-12-05 13:44:10 UTC) #2
Nico
https://codereview.chromium.org/104803006/diff/1/build/gyp_chromium File build/gyp_chromium (right): https://codereview.chromium.org/104803006/diff/1/build/gyp_chromium#newcode211 build/gyp_chromium:211: #if not RunGN(supplemental_includes): This change is enough to revert. ...
7 years ago (2013-12-05 16:50:37 UTC) #3
Nico
Actually, I'll land this for you. On Thu, Dec 5, 2013 at 8:50 AM, <thakis@chromium.org> ...
7 years ago (2013-12-05 16:52:08 UTC) #4
Nico
Landed in r238982
7 years ago (2013-12-05 16:55:28 UTC) #5
pmeenan
7 years ago (2013-12-05 18:39:31 UTC) #6
Thanks for your help - builder made it past the runhooks successfully now:
http://build.chromium.org/p/chromium.perf/builders/Win%20Builder/builds/63708


On Thu, Dec 5, 2013 at 11:55 AM, <thakis@chromium.org> wrote:

> Landed in r238982
>
> https://codereview.chromium.org/104803006/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698