Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Unified Diff: Source/bindings/tests/results/core/V8TestDictionary.cpp

Issue 1047993002: bindings: Add validation for enum Sequence or Array (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/core/V8TestDictionary.cpp
diff --git a/Source/bindings/tests/results/core/V8TestDictionary.cpp b/Source/bindings/tests/results/core/V8TestDictionary.cpp
index 62cd43d3da1ece5601f0e2149585d5b383255f6e..bd1af48bf46c015d331034c0b5ca0afed744dd33 100644
--- a/Source/bindings/tests/results/core/V8TestDictionary.cpp
+++ b/Source/bindings/tests/results/core/V8TestDictionary.cpp
@@ -130,9 +130,14 @@ void V8TestDictionary::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8Value
V8StringResource<> enumMember = enumMemberValue;
if (!enumMember.prepare(exceptionState))
return;
- String string = enumMember;
- if (!(string == "" || string == "EnumValue1" || string == "EnumValue2" || string == "EnumValue3")) {
- exceptionState.throwTypeError("member enumMember ('" + string + "') is not a valid enum value.");
+ static const char* validValues[] = {
+ "",
+ "EnumValue1",
+ "EnumValue2",
+ "EnumValue3",
+ };
+ if (!isValidEnum(enumMember, validValues, WTF_ARRAY_LENGTH(validValues))) {
+ exceptionState.throwTypeError("member enumMember ('" + toCoreString(isolate, enumMemberValue) + "') is not a valid enum value.");
haraken 2015/04/01 00:29:45 Can we just use enumMember (not toCoreString(enumM
bashi 2015/04/01 00:50:57 I don't think we want to do it because it requires
return;
}
impl.setEnumMember(enumMember);

Powered by Google App Engine
This is Rietveld 408576698