bindings: Add validation for enum Sequence or Array

Source/bindings/tests/results/core/V8TestDictionary.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file has been auto-generated by code_generator_v8.py. DO NOT MODIFY!
 
 #include "config.h"
 #include "V8TestDictionary.h"
 
 #include "bindings/core/v8/ExceptionState.h"
@@ skipping 112 matching lines @@
     if (block.HasCaught()) {
         exceptionState.rethrowV8Exception(block.Exception());
         return;
     }
     if (enumMemberValue.IsEmpty() || enumMemberValue->IsUndefined()) {
         // Do nothing.
     } else {
         V8StringResource<> enumMember = enumMemberValue;
         if (!enumMember.prepare(exceptionState))
             return;
-        String string = enumMember;
-        if (!(string == "" || string == "EnumValue1" || string == "EnumValue2" || string == "EnumValue3")) {
-            exceptionState.throwTypeError("member enumMember ('" + string + "') is not a valid enum value.");
+        static const char* validValues[] = {
+            "",
+            "EnumValue1",
+            "EnumValue2",
+            "EnumValue3",
+        };
+        if (!isValidEnum(enumMember, validValues, WTF_ARRAY_LENGTH(validValues))) {
+            exceptionState.throwTypeError("member enumMember ('" + toCoreString(isolate, enumMemberValue) + "') is not a valid enum value.");

[haraken, 2015/04/01 00:29:45]

Can we just use enumMember (not toCoreString(enumMemberValue))?

[bashi, 2015/04/01 00:50:57]

I don't think we want to do it because it requires two branches in Jinja
templates. A member may be a string, but also can be a vector. That's why I use
toCoreString here.

Added a sequence<TestEnum> in TestDictionary.idl to explain this. (I thought I
added it, but it seems I didn't...)

             return;
         }
         impl.setEnumMember(enumMember);
     }
 
     v8::Local<v8::Value> eventTargetMemberValue = v8Object->Get(v8String(isolate, "eventTargetMember"));
     if (block.HasCaught()) {
         exceptionState.rethrowV8Exception(block.Exception());
         return;
     }
@@ skipping 444 matching lines @@
 }
 
 TestDictionary NativeValueTraits<TestDictionary>::nativeValue(v8::Isolate* isolate, v8::Local<v8::Value> value, ExceptionState& exceptionState)
 {
     TestDictionary impl;
     V8TestDictionary::toImpl(isolate, value, impl, exceptionState);
     return impl;
 }
 
 } // namespace blink