Issue 1047953002: worker: Fix a bad static-cast.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1047953002: worker: Fix a bad static-cast. (Closed)

Created:
5 years, 8 months ago by sadrul

Modified:
5 years, 8 months ago

Reviewers:
tkent

CC:
blink-reviews, kinuko+worker_chromium.org, horo+watch_chromium.org, falken

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

worker: Fix a bad static-cast. For CompositorWorker, the WorkerGlobalScope is a CompositorWorkerGlobalScope, and not a DedicatedWorkerGlobalScope. So fix the bad cast by teaching the task about the WorkerObjectProxy on creation (since WorkerMessagagingProxy already knows about it without having to depend on the WorkerGlobalScope or the WorkerThread). BUG=471785 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192810

Patch Set 1 #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -10 lines)			Patch
	M	Source/core/workers/WorkerMessagingProxy.cpp	View		3 chunks	+12 lines, -10 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1047953002/1

5 years, 8 months ago (2015-03-31 03:53:50 UTC) #5

commit-bot: I haz the power

5 years, 8 months ago (2015-03-31 07:08:18 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192810

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages