Cache --whitelisted-extension-id in SimpleFeature.

extensions/common/features/simple_feature.h

Index: extensions/common/features/simple_feature.h
diff --git a/extensions/common/features/simple_feature.h b/extensions/common/features/simple_feature.h
index 9d8c539414bb42f775911dbd76fa7c1cbaed192f..9318ef210b848f4dd11f003b213f10ccce849887 100644
--- a/extensions/common/features/simple_feature.h
+++ b/extensions/common/features/simple_feature.h
@@ -87,6 +87,9 @@ class SimpleFeature : public Feature {
                           const char* const array[],
                           size_t array_length);
 
+  // Used by tests to override the cached --whitelisted-extension-id.
+  static void SetWhitelistedExtensionId(const std::string& id);

[not at google - send to devlin, 2015/04/08 17:59:22]

I prefer to only provide RAII versions of these set-for-testing flags, in this
case, perhaps a "ScopedWhitelist[ForTest]" class similar to the
ScopedCurrentChannel class. That would solve the memory leak issue, and really
definitely make the unit tests isolated.

[jackhou1, 2015/04/09 07:23:28]

Done.

+
  protected:
   // Similar to Manifest::Location, these are the classes of locations
   // supported in feature files. Production code should never directly access