Cache --whitelisted-extension-id in SimpleFeature.

extensions/common/features/simple_feature.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_COMMON_FEATURES_SIMPLE_FEATURE_H_
 #define EXTENSIONS_COMMON_FEATURES_SIMPLE_FEATURE_H_
 
 #include <set>
 #include <string>
 #include <vector>
@@ skipping 69 matching lines @@
 
   bool IsInternal() const override;
 
   bool IsIdInBlacklist(const std::string& extension_id) const override;
   bool IsIdInWhitelist(const std::string& extension_id) const override;
 
   static bool IsIdInArray(const std::string& extension_id,
                           const char* const array[],
                           size_t array_length);
 
+  // Used by tests to override the cached --whitelisted-extension-id.
+  static void SetWhitelistedExtensionId(const std::string& id);

[not at google - send to devlin, 2015/04/08 17:59:22]

I prefer to only provide RAII versions of these set-for-testing flags, in this
case, perhaps a "ScopedWhitelist[ForTest]" class similar to the
ScopedCurrentChannel class. That would solve the memory leak issue, and really
definitely make the unit tests isolated.

[jackhou1, 2015/04/09 07:23:28]

Done.

+
  protected:
   // Similar to Manifest::Location, these are the classes of locations
   // supported in feature files. Production code should never directly access
   // these.
   enum Location {
     UNSPECIFIED_LOCATION,
     COMPONENT_LOCATION,
     EXTERNAL_COMPONENT_LOCATION,
     POLICY_LOCATION,
   };
@@ skipping 92 matching lines @@
   std::string command_line_switch_;
 
   ScopedVector<SimpleFeatureFilter> filters_;;
 
   DISALLOW_COPY_AND_ASSIGN(SimpleFeature);
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_COMMON_FEATURES_SIMPLE_FEATURE_H_