Fix gyp: duplicate target definitions for third_party/icu/icu.gyp:icudata#target

Fix gyp: duplicate target definitions for third_party/icu/icu.gyp:icudata#target

When use_system_icu=1 and want_separate_host_toolset=1, icudata target is
defined twice.

BUG=341104

[jochen (gone - plz use gerrit), 2013-12-20 07:54:25]

+jshin

[dshwang, 2013-12-30 08:30:32]

could you review?

[jochen (gone - plz use gerrit), 2014-01-03 14:36:10]

I believe this is already fixed in r241739 ?

[dshwang, 2014-01-03 15:54:07]

On 2014/01/03 14:36:10, jochen wrote:
> I believe this is already fixed in r241739 ?

r241739 is https://codereview.chromium.org/118373006 and is not related to this
bug.
master branch of icu still has this issue.

[dshwang, 2014-01-03 15:59:38]

this CL should be updated. I'll update soon.

[dshwang, 2014-01-03 16:30:39]

This issue can be reproduced by following steps.
> export GYP_GENERATORS='ninja'
> ./build/gyp_chromium -Duse_system_icu=1

Strangely, this bug can not be reproduced when using 'make'; (export
GYP_GENERATORS='make')

I changed the logic for want_separate_host_toolset to be the same to v8.gyp. And
it looks like make sense.
When want_separate_host_toolset = 1, build for both host and target. otherwise,
build for only target.
        ['want_separate_host_toolset==1', {
          'toolsets': ['host', 'target'],
        }, {
          'toolsets': ['target'],
        }],

However, I'm not sure 100%, so I hope Owner review this CL.

[jochen (gone - plz use gerrit), 2014-01-03 16:36:22]

the logic should be like this:

if want_separate_host_toolset == 0 and use_system_icu == 0

  don't use system icu
  build icu for target toolset

elif want_separate_host_toolset == 0 and use_system_icu == 1

  use system icu for target toolset
  don't build icu

elif want_separate_host_toolset == 1 and use_system_icu == 0

  don't use system icu
  build icu for host and target

elif want_separate_host_toolset == 1 and use_system_icu == 1

  use system icu for target toolset
  build icu for host toolset

[jungshik at Google, 2014-01-03 19:28:15]

On 2014/01/03 16:36:22, jochen wrote:
> the logic should be like this:
> 
> if want_separate_host_toolset == 0 and use_system_icu == 0
> 
>   don't use system icu
>   build icu for target toolset
> 
> elif want_separate_host_toolset == 0 and use_system_icu == 1
> 
>   use system icu for target toolset
>   don't build icu
> 
> elif want_separate_host_toolset == 1 and use_system_icu == 0
> 
>   don't use system icu
>   build icu for host and target
> 
> elif want_separate_host_toolset == 1 and use_system_icu == 1
> 
>   use system icu for target toolset
>   build icu for host toolset

sorry for the late reply. I was back yesterday. I agree with jochen about the
logic.

[dshwang, 2014-01-03 20:29:23]

On 2014/01/03 19:28:15, Jungshik Shin wrote:
> On 2014/01/03 16:36:22, jochen wrote:
> > the logic should be like this:
> > 
> > if want_separate_host_toolset == 0 and use_system_icu == 0
> > 
> >   don't use system icu
> >   build icu for target toolset
> > 
> > elif want_separate_host_toolset == 0 and use_system_icu == 1
> > 
> >   use system icu for target toolset
> >   don't build icu
> > 
> > elif want_separate_host_toolset == 1 and use_system_icu == 0
> > 
> >   don't use system icu
> >   build icu for host and target
> > 
> > elif want_separate_host_toolset == 1 and use_system_icu == 1
> > 
> >   use system icu for target toolset
> >   build icu for host toolset
> 
> sorry for the late reply. I was back yesterday. I agree with jochen about the
> logic.

Thank you for explanation of expected logic.
I file another CL to fix the logic: https://codereview.chromium.org/124003004/
Could you review the another CL?

However ninja + use_system_icu == 1 still has this issue.
When GYP_GENERATORS='make', following gyp code stub can be handled, but when
GYP_GENERATORS='ninja', gyping fails with following msg:
ERR MSG: gyp: Duplicate target definitions for
/home/dshwang/workspace/chromium/blink/src/third_party/icu/icu.gyp:icudata#target
    {
      'target_name': 'icudata',
      'toolsets': ['target'],
      ... // target logic
    },
    {
      'target_name': 'icudata',
      'toolsets': ['host'],
      ... // host logic
    },  

in my opinion, it is a gyp bug. WDYT?

[dshwang, 2014-01-03 20:36:42]

https://codereview.chromium.org/104793004/diff/150001/icu.gyp
File icu.gyp (right):

https://codereview.chromium.org/104793004/diff/150001/icu.gyp#newcode78
icu.gyp:78: 'export_dependent_settings': ['system_icudata'],
I try to not build it for target toolset as above:
because gyp with ninja can not handle following code stub.

    {
      'target_name': 'icudata',
      'toolsets': ['target'],
      ... // target logic
    },
    {
      'target_name': 'icudata',
      'toolsets': ['host'],
      ... // host logic
    },  

Unfortunately, this trying fails because gyp does not allow changing 'type' and
'dependencies' in 'target_conditions'.

I think the best solution is fixing GYP with ninja.

[marja, 2014-01-07 08:44:19]

(Removing myself from the reviewer list, as jochen@ has had a look already...)