Add back link_settings for iOS.

Add back link_settings for iOS.

In https://codereview.chromium.org/111723007, link_settings was dropped on
all platforms including iOS. iOS does need link_settings (see
post-checkin comments in the CL aforementioned).

BUG=72633
TEST=Once this is rolled in, ios* bots pass *unittests without an error in loading icudtl.dat.
R=mark@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241739

[jungshik at Google, 2013-12-18 22:51:35]

Can you take a look? I followed your advice.

[Mark Mentovai, 2013-12-18 23:31:28]

LGTM, but consider this suggestion.

You can check in as-is or implement this suggestion. I won’t be around tonight
to LG any updates because it’s our holiday party, but the LGTM stands either
way.

https://codereview.chromium.org/118373006/diff/20001/icu.gyp
File icu.gyp (right):

https://codereview.chromium.org/118373006/diff/20001/icu.gyp#newcode101
icu.gyp:101: 'conditions': [
Why don’t you just make it one conditional with an else, like

'conditions': [
  ['OS!="ios", {
    'copies': [
      # …
    ],
  }, {  # else: OS=="ios"
    'link_settings': {
      # …
    },
  }],  # OS!="ios"
},  # conditions

[jungshik at Google, 2013-12-19 01:17:03]

Thanks again for the review and help. I implemented your suggestion in ps 3/4
and am landing. 
Happy holidays ! :-) 


On 2013/12/18 23:31:28, Mark Mentovai wrote:
> LGTM, but consider this suggestion.
> 
> You can check in as-is or implement this suggestion. I won’t be around tonight
> to LG any updates because it’s our holiday party, but the LGTM stands either
> way.
> 
> https://codereview.chromium.org/118373006/diff/20001/icu.gyp
> File icu.gyp (right):
> 
> https://codereview.chromium.org/118373006/diff/20001/icu.gyp#newcode101
> icu.gyp:101: 'conditions': [
> Why don’t you just make it one conditional with an else, like
> 
> 'conditions': [
>   ['OS!="ios", {
>     'copies': [
>       # …
>     ],
>   }, {  # else: OS=="ios"
>     'link_settings': {
>       # …
>     },
>   }],  # OS!="ios"
> },  # conditions

[jungshik at Google, 2013-12-19 01:17:34]

Committed patchset #4 manually as r241739 (presubmit successful).