Fix polymorphic inlined calls with migrating prototypes

Fix polymorphic inlined calls with migrating prototypes

LOG=Y
R=verwaest@chromium.org

Committed: http://code.google.com/p/v8/source/detail?r=18307

[Jakob Kummerow, 2013-12-09 13:03:36]

PTAL.

We'll have to backmerge this to all branches we still care about.

[Toon Verwaest, 2013-12-09 16:32:58]

Nice long-overdue cleanup! Just one comment.

https://codereview.chromium.org/104793003/diff/20001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/104793003/diff/20001/src/objects.cc#newcode3891
src/objects.cc:3891: Handle<Map> new_map =
Map::CurrentMapForDeprecated(original_map);
Euh, yeah. Now CurrentMapForDeprecated links back to this method for every
prototype. So we have a nice O(n^2) algorithm :)

[Jakob Kummerow, 2013-12-10 11:06:22]

https://codereview.chromium.org/104793003/diff/20001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/104793003/diff/20001/src/objects.cc#newcode3891
src/objects.cc:3891: Handle<Map> new_map =
Map::CurrentMapForDeprecated(original_map);
On 2013/12/09 16:32:59, Toon Verwaest wrote:
> Euh, yeah. Now CurrentMapForDeprecated links back to this method for every
> prototype. So we have a nice O(n^2) algorithm :)

Done.

[Toon Verwaest, 2013-12-10 11:14:39]

LGTM.

May be nice to make the Internal method protected though.

[Jakob Kummerow, 2013-12-10 12:00:11]

On 2013/12/10 11:14:39, Toon Verwaest wrote:
> May be nice to make the Internal method protected though.

I'd love to, but it's called from JSObject::TryMigrateInstance, so I'd have to
make that a friend. I don't like friends :-P

[Jakob Kummerow, 2013-12-12 14:57:12]

Committed patchset #3 manually as r18307.