Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: src/typing.cc

Issue 104793003: Fix polymorphic inlined calls with migrating prototypes (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: fixed inefficient recursion Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/type-info.cc ('k') | test/mjsunit/regress/regress-calls-with-migrating-prototypes.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/typing.cc
diff --git a/src/typing.cc b/src/typing.cc
index 8487c05eb4af9fe472509c5afc34ae0eb1916053..9458d6dc2fe401142f7b4e3392cea419fe94500c 100644
--- a/src/typing.cc
+++ b/src/typing.cc
@@ -394,8 +394,6 @@ void AstTyper::VisitAssignment(Assignment* expr) {
expr->set_is_uninitialized(oracle()->StoreIsUninitialized(id));
if (!expr->IsUninitialized()) {
expr->set_is_pre_monomorphic(oracle()->StoreIsPreMonomorphic(id));
- expr->set_is_monomorphic(oracle()->StoreIsMonomorphicNormal(id));
- ASSERT(!expr->IsPreMonomorphic() || !expr->IsMonomorphic());
if (prop->key()->IsPropertyName()) {
Literal* lit_key = prop->key()->AsLiteral();
ASSERT(lit_key != NULL && lit_key->value()->IsString());
@@ -407,6 +405,7 @@ void AstTyper::VisitAssignment(Assignment* expr) {
id, expr->GetReceiverTypes(), &store_mode);
expr->set_store_mode(store_mode);
}
+ ASSERT(!expr->IsPreMonomorphic() || !expr->IsMonomorphic());
}
}
@@ -445,8 +444,6 @@ void AstTyper::VisitProperty(Property* expr) {
expr->set_is_uninitialized(oracle()->LoadIsUninitialized(id));
if (!expr->IsUninitialized()) {
expr->set_is_pre_monomorphic(oracle()->LoadIsPreMonomorphic(id));
- expr->set_is_monomorphic(oracle()->LoadIsMonomorphicNormal(id));
- ASSERT(!expr->IsPreMonomorphic() || !expr->IsMonomorphic());
if (expr->key()->IsPropertyName()) {
Literal* lit_key = expr->key()->AsLiteral();
ASSERT(lit_key != NULL && lit_key->value()->IsString());
@@ -461,6 +458,7 @@ void AstTyper::VisitProperty(Property* expr) {
id, expr->GetReceiverTypes(), &is_string);
expr->set_is_string_access(is_string);
}
+ ASSERT(!expr->IsPreMonomorphic() || !expr->IsMonomorphic());
}
RECURSE(Visit(expr->obj()));
@@ -551,7 +549,6 @@ void AstTyper::VisitUnaryOperation(UnaryOperation* expr) {
void AstTyper::VisitCountOperation(CountOperation* expr) {
// Collect type feedback.
TypeFeedbackId store_id = expr->CountStoreFeedbackId();
- expr->set_is_monomorphic(oracle()->StoreIsMonomorphicNormal(store_id));
expr->set_store_mode(oracle()->GetStoreMode(store_id));
oracle()->CountReceiverTypes(store_id, expr->GetReceiverTypes());
expr->set_type(oracle()->CountType(expr->CountBinOpFeedbackId()));
« no previous file with comments | « src/type-info.cc ('k') | test/mjsunit/regress/regress-calls-with-migrating-prototypes.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698