Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 1047893002: Turn off selection gap painting, but allow toggling via a runtime flag (Closed)

Created:
5 years, 8 months ago by chrishtr
Modified:
5 years, 4 months ago
Reviewers:
pdr., esprehn, eae
CC:
blink-reviews, blink-reviews-rendering, Dominik Röttsches, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Turn off selection gap painting, but allow toggling via a runtime flag. BUG=471908

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -21 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 4 5 6 7 2 chunks +138 lines, -1 line 0 comments Download
D LayoutTests/fast/block/line-layout/selection-highlight-overlap-expected.html View 1 2 1 chunk +0 lines, -19 lines 0 comments Download
M Source/core/layout/LayoutBlockFlow.cpp View 1 2 3 4 5 6 7 1 chunk +3 lines, -1 line 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
chrishtr
For review. I won't commit until the blink-dev proposal corresponding to this is confirmed.
5 years, 8 months ago (2015-03-31 23:08:34 UTC) #2
chrishtr
5 years, 8 months ago (2015-03-31 23:08:44 UTC) #4
eae
LGTM (pending blink-dev discussion)
5 years, 8 months ago (2015-03-31 23:13:11 UTC) #5
eae
Did we ever reach a conclusion on the blink-dev thread?
5 years, 7 months ago (2015-05-27 21:16:34 UTC) #6
chrishtr
On 2015/05/27 at 21:16:34, eae wrote: > Did we ever reach a conclusion on the ...
5 years, 6 months ago (2015-05-28 20:40:52 UTC) #7
eae
Ok, please keep me posted. Would be really nice if we could get rid of ...
5 years, 6 months ago (2015-05-28 20:52:59 UTC) #8
eae
Any update on this?
5 years, 4 months ago (2015-08-25 00:17:22 UTC) #9
chrishtr
5 years, 4 months ago (2015-08-25 00:18:14 UTC) #10
wkorman took this over. Closing this review.

Powered by Google App Engine
This is Rietveld 408576698