Source/core/layout/LayoutBlockFlow.cpp - Issue 1047893002: Turn off selection gap painting, but allow toggling via a runtime flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/LayoutBlockFlow.cpp

Issue 1047893002: Turn off selection gap painting, but allow toggling via a runtime flag (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/block/line-layout/selection-highlight-overlap-expected.html ('k') | Source/platform/RuntimeEnabledFeatures.in » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/layout/LayoutBlockFlow.cpp

diff --git a/Source/core/layout/LayoutBlockFlow.cpp b/Source/core/layout/LayoutBlockFlow.cpp

index eefe84afaa54d6ede41a6162b7669b3f7f2d46f3..4732f30cb50061626e9b58c02a5b0869fb164b9a 100644

--- a/Source/core/layout/LayoutBlockFlow.cpp

+++ b/Source/core/layout/LayoutBlockFlow.cpp

@@ -2843,7 +2843,9 @@ IntRect alignSelectionRectToDevicePixels(LayoutRect& rect)

bool LayoutBlockFlow::shouldPaintSelectionGaps() const

{

- return selectionState() != SelectionNone && style()->visibility() == VISIBLE && isSelectionRoot();

+ // TODO(chrishtr): remove the feature once we are sure it will be ok to do so. See crbug.com/471908 for more details.

+ return RuntimeEnabledFeatures::selectionGapPaintingEnabled()

+ && selectionState() != SelectionNone && style()->visibility() == VISIBLE && isSelectionRoot();

}

LayoutRect LayoutBlockFlow::blockSelectionGap(const LayoutBlock* rootBlock, const LayoutPoint& rootBlockPhysicalPosition, const LayoutSize& offsetFromRootBlock,