Re-enable scan thresholds when opening folder

Re-enable scan thresholds when opening folder
Committed: https://code.google.com/p/dart/source/detail?r=8227

[devoncarew, 2012-06-03 16:35:53]

lgtm

http://codereview.chromium.org/10477005/diff/1/editor/tools/plugins/com.googl...
File
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/AnalysisServer.java
(right):

http://codereview.chromium.org/10477005/diff/1/editor/tools/plugins/com.googl...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/AnalysisServer.java:316:
public void scan(File file, boolean fullScan) {
I'd add another scan() method w/ only a File parameter, and have it call through
to scan(File, boolean) with a true arg for fullScan. Then I'd change all the
call sites to use the shorter scan method, except where they explicitly want the
threshold behavior.

http://codereview.chromium.org/10477005/diff/1/editor/tools/plugins/com.googl...
File
editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/analysis/AnalysisServerTest.java
(right):

http://codereview.chromium.org/10477005/diff/1/editor/tools/plugins/com.googl...
editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/analysis/AnalysisServerTest.java:358:
server.scan(sourcedFile, false);
I think the 4 invocations of this method should pass in true - they should get
the thresholding behavior (or call the shorter version of the method that I
propose).

[danrubel, 2012-06-03 18:28:12]

http://codereview.chromium.org/10477005/diff/1/editor/tools/plugins/com.googl...
File
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/AnalysisServer.java
(right):

http://codereview.chromium.org/10477005/diff/1/editor/tools/plugins/com.googl...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/AnalysisServer.java:316:
public void scan(File file, boolean fullScan) {
On 2012/06/03 16:35:53, devoncarew wrote:
> I'd add another scan() method w/ only a File parameter, and have it call
through
> to scan(File, boolean) with a true arg for fullScan. Then I'd change all the
> call sites to use the shorter scan method, except where they explicitly want
the
> threshold behavior.

I'd rather have it apparent at each call site that there is a choice to be made.
Having a method without the 2nd argument hides that choice in my opinion.

http://codereview.chromium.org/10477005/diff/1/editor/tools/plugins/com.googl...
File
editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/analysis/AnalysisServerTest.java
(right):

http://codereview.chromium.org/10477005/diff/1/editor/tools/plugins/com.googl...
editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/analysis/AnalysisServerTest.java:358:
server.scan(sourcedFile, false);
On 2012/06/03 16:35:53, devoncarew wrote:
> I think the 4 invocations of this method should pass in true - they should get
> the thresholding behavior (or call the shorter version of the method that I
> propose).

Sorry... I'm confused as to which you are recommending...

1) passing true so that there will be a full scan and no threshold checking
-- or --
2) passing false so that it will be not be a full scan and the "thresholding
behavior" will be enabled

[devoncarew, 2012-06-04 00:51:57]

lgtm

http://codereview.chromium.org/10477005/diff/1/editor/tools/plugins/com.googl...
File
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/AnalysisServer.java
(right):

http://codereview.chromium.org/10477005/diff/1/editor/tools/plugins/com.googl...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/AnalysisServer.java:316:
public void scan(File file, boolean fullScan) {
Well, your call, but I think we only want this behavior in one case, and every
other call site will use the non-thresholding behavior. I think it's safer if we
make the shorter method have the general case behavior and the longer version of
the method allow more specialization. But it's a nit - submit whichever version
you think best.

http://codereview.chromium.org/10477005/diff/1/editor/tools/plugins/com.googl...
File
editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/analysis/AnalysisServerTest.java
(right):

http://codereview.chromium.org/10477005/diff/1/editor/tools/plugins/com.googl...
editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/analysis/AnalysisServerTest.java:358:
server.scan(sourcedFile, false);
Ack! That should have read "shouldn't get the thresholding behavior". I don't
think you should make the thresholding behavior part of these unit tests.

[danrubel, 2012-06-04 06:12:42]

http://codereview.chromium.org/10477005/diff/1/editor/tools/plugins/com.googl...
File
editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/analysis/AnalysisServerTest.java
(right):

http://codereview.chromium.org/10477005/diff/1/editor/tools/plugins/com.googl...
editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/analysis/AnalysisServerTest.java:358:
server.scan(sourcedFile, false);
On 2012/06/04 00:51:57, devoncarew wrote:
> Ack! That should have read "shouldn't get the thresholding behavior". I don't
> think you should make the thresholding behavior part of these unit tests.

Good point.
Updated tests in subsequent CL.
http://codereview.chromium.org/10513002/