Re-enable scan thresholds when opening folder

editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/AnalysisServer.java

Index: editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/AnalysisServer.java
===================================================================
--- editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/AnalysisServer.java	(revision 8212)
+++ editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/AnalysisServer.java	(working copy)
@@ -303,10 +303,18 @@
   }
 
   /**
-   * Recursively scan the specified directory for libraries to analyze
+   * Scan the specified file or recursively scan the specified directory for libraries to analyze.
+   * If the fullScan parameter is <code>false</code> and the scan takes too long or includes too
+   * many bytes of Dart source code, then the scan will stop and the specified folder marked so that
+   * it will not be analyzed.
+   * 
+   * @param file the file or directory of files to scan (not <code>null</code>)
+   * @param fullScan <code>true</code> if the scan should recurse infinitely deep and for however
+   *          long the scan takes or <code>false</code> if the scan should stop once the time or
+   *          size threshold has been reached.
    */
-  public void scan(File file) {
-    queueNewTask(new LibraryScanTask(this, savedContext, file));
+  public void scan(File file, boolean fullScan) {

[devoncarew, 2012/06/03 16:35:53]

I'd add another scan() method w/ only a File parameter, and have it call through
to scan(File, boolean) with a true arg for fullScan. Then I'd change all the
call sites to use the shorter scan method, except where they explicitly want the
threshold behavior.

[danrubel, 2012/06/03 18:28:12]

I'd rather have it apparent at each call site that there is a choice to be made.
Having a method without the 2nd argument hides that choice in my opinion.

[devoncarew, 2012/06/04 00:51:57]

Well, your call, but I think we only want this behavior in one case, and every
other call site will use the non-thresholding behavior. I think it's safer if we
make the shorter method have the general case behavior and the longer version of
the method allow more specialization. But it's a nit - submit whichever version
you think best.

+    queueNewTask(new LibraryScanTask(this, savedContext, file, fullScan));
   }
 
   /**