Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Issue 1047613002: Revert of [Telemetry] Do not close tab connections if the tab is already gone. (Closed)

Created:
5 years, 8 months ago by slamm
Modified:
5 years, 8 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Telemetry] Do not close tab connections if the tab is already gone. (patchset #2 id:20001 of https://codereview.chromium.org/1041843002/) Reason for revert: https://crbug.com/471512 Flaky telemetry_perf_unittests on all platforms due to ChromeTracingStartedError Setting current_tab to None should be done for the crash tab/app errors only. Also, consider guarding the other clean-up methods that use it, or make sure they can dean with a None value. Original issue's description: > [Telemetry] Do not close tab connections if the tab is already gone. > Update tests so they check for formatted exceptions (so they will catch > a bug such as this one). > > BUG=444240 > > Committed: https://crrev.com/86133f6e51b06f58afdcf4b00e65ffb3f510f34b > Cr-Commit-Position: refs/heads/master@{#322613} TBR=nednguyen@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=444240 Committed: https://crrev.com/ea14d2b3e757e609fd8fb4cdc580bdcfc591d8ae Cr-Commit-Position: refs/heads/master@{#322738}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -43 lines) Patch
M tools/telemetry/telemetry/page/page_run_end_to_end_unittest.py View 12 chunks +16 lines, -40 lines 0 comments Download
M tools/telemetry/telemetry/page/shared_page_state.py View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
slamm
Created Revert of [Telemetry] Do not close tab connections if the tab is already gone.
5 years, 8 months ago (2015-03-30 04:00:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1047613002/1
5 years, 8 months ago (2015-03-30 04:00:12 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-03-30 04:00:33 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-03-30 04:01:04 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ea14d2b3e757e609fd8fb4cdc580bdcfc591d8ae
Cr-Commit-Position: refs/heads/master@{#322738}

Powered by Google App Engine
This is Rietveld 408576698