tools/telemetry/telemetry/page/shared_page_state.py - Issue 1047613002: Revert of [Telemetry] Do not close tab connections if the tab is already gone.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/shared_page_state.py

Issue 1047613002: Revert of [Telemetry] Do not close tab connections if the tab is already gone. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/page/shared_page_state.py

diff --git a/tools/telemetry/telemetry/page/shared_page_state.py b/tools/telemetry/telemetry/page/shared_page_state.py

index 620e3731fd14f496b87940e8d20687645b9a8c11..0e564f8f8eac99a3b5eb2019556ba62a37bba81e 100644

--- a/tools/telemetry/telemetry/page/shared_page_state.py

+++ b/tools/telemetry/telemetry/page/shared_page_state.py

@@ -84,8 +84,7 @@

def DidRunUserStory(self, results):

if self._finder_options.profiler:

self._StopProfiling(results)

- if self._current_tab:

- util.CloseConnections(self._current_tab)

+ util.CloseConnections(self._current_tab)

self._test.CleanUpAfterPage(self._current_page, self._current_tab)

if self._current_page.credentials and self._did_login_for_current_page:

self.browser.credentials.LoginNoLongerNeeded(

@@ -254,7 +253,6 @@

self._ImplicitPageNavigation()

self._test.RunPage(self._current_page, self._current_tab, results)

except exceptions.Error:

- self._current_tab = None

if self._test.is_multi_tab_test:

# Avoid trying to recover from an unknown multi-tab state.

exception_formatter.PrintFormattedException(

« no previous file with comments | « tools/telemetry/telemetry/page/page_run_end_to_end_unittest.py ('k') | no next file » | no next file with comments »