Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Unified Diff: LayoutTests/fast/images/onload-event-when-reloading-image-after-successful-image-load.html

Issue 1047563002: Fire load event for an image even if it was the last image we loaded successfully. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Updated Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/images/onload-event-when-reloading-image-after-successful-image-load.html
diff --git a/LayoutTests/fast/images/onload-event-when-reloading-image-after-successful-image-load.html b/LayoutTests/fast/images/onload-event-when-reloading-image-after-successful-image-load.html
new file mode 100644
index 0000000000000000000000000000000000000000..ae2c6e8c0f3581cccb1bcb30bfb90c072ecd2445
--- /dev/null
+++ b/LayoutTests/fast/images/onload-event-when-reloading-image-after-successful-image-load.html
@@ -0,0 +1,40 @@
+<!DOCTYPE html>
+<script src="../../resources/js-test.js"></script>
+<script>
+ if (window.testRunner) {
+ testRunner.waitUntilDone();
+ testRunner.dumpAsText();
esprehn 2015/04/06 20:31:35 js-test already sets dumpAsText, and you can do so
+ }
+ img = new Image();
+ var onloadCounter = 0;
+ var testImage = 'resources/green.jpg';
+ var resetImage = 'resources/green.jpg';
+ img.onload = function(){
+ onloadCounter++;
+ debug("Image onload event fired for " + img.src.substring(img.src.lastIndexOf('/') + 1));
+ if (onloadCounter == 2) {
+ document.getElementById('result').textContent = "PASS";
+ if (window.testRunner)
+ testRunner.notifyDone();
esprehn 2015/04/06 20:31:36 finishJSTest(), you don't even need to mention tes
+ return;
+ }
+ if (onloadCounter == 1) {
+ setTimeout(function() {
+ img.src= resetImage;
+ img.src = testImage;
+ }, 0);
+ return;
+ }
+ document.getElementById('result').textContent = "FAIL";
+ };
+ setTimeout(function() {
+ img.src= resetImage;
Yoav Weiss 2015/04/02 07:52:10 same question
+ img.src = testImage;
+ }, 0);
+</script>
+<div id="console">
+crbug.com/469678: We should fire an image load event even if the image is the last one we loaded successfully.<br>
esprehn 2015/04/06 20:31:36 Generally this goes in the description("") call in
+In this test we load an image then we immediately launch an other request for the same image - only one load event should be fired.<br>
+Then we do the same again: another load event should be fired.<br>
+</div>
+<div id="result">FAIL</div>

Powered by Google App Engine
This is Rietveld 408576698