LayoutTests/fast/images/onload-event-when-reloading-image-after-successful-image-load.html - Issue 1047563002: Fire load event for an image even if it was the last image we loaded successfully.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/images/onload-event-when-reloading-image-after-successful-image-load.html

Issue 1047563002: Fire load event for an image even if it was the last image we loaded successfully. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Updated Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/fast/images/onload-event-when-reloading-image-after-interrupted-broken-image-load.html ('K') | « LayoutTests/fast/images/onload-event-when-reloading-image-after-interrupted-broken-image-load-expected.txt ('k') | LayoutTests/fast/images/onload-event-when-reloading-image-after-successful-image-load-expected.txt » ('j') | Source/core/loader/ImageLoader.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/js-test.js"></script>

	3 <script>

	4 if (window.testRunner) {

	5 testRunner.waitUntilDone();

	6 testRunner.dumpAsText();
	esprehn 2015/04/06 20:31:35 js-test already sets dumpAsText, and you can do so js-test already sets dumpAsText, and you can do something like jsTestAsync = true and it'll deal with the waitUntilDone(). Then you do finishJSTest() in the async function to finish the test.
	7 }

	8 img = new Image();

	9 var onloadCounter = 0;

	10 var testImage = 'resources/green.jpg';

	11 var resetImage = 'resources/green.jpg';

	12 img.onload = function(){

	13 onloadCounter++;

	14 debug("Image onload event fired for " + img.src.substring(img.src.lastIn dexOf('/') + 1));

	15 if (onloadCounter == 2) {

	16 document.getElementById('result').textContent = "PASS";

	17 if (window.testRunner)

	18 testRunner.notifyDone();
	esprehn 2015/04/06 20:31:36 finishJSTest(), you don't even need to mention tes finishJSTest(), you don't even need to mention testRunner anywhere in this test.
	19 return;

	20 }

	21 if (onloadCounter == 1) {

	22 setTimeout(function() {

	23 img.src= resetImage;

	24 img.src = testImage;

	25 }, 0);

	26 return;

	27 }

	28 document.getElementById('result').textContent = "FAIL";

	29 };

	30 setTimeout(function() {

	31 img.src= resetImage;
	Yoav Weiss 2015/04/02 07:52:10 same question same question
	32 img.src = testImage;

	33 }, 0);

	34 </script>

	35 <div id="console">

	36 crbug.com/469678: We should fire an image load event even if the image is the la st one we loaded successfully.<br>
	esprehn 2015/04/06 20:31:36 Generally this goes in the description("") call in Generally this goes in the description("") call instead of inline like this.
	37 In this test we load an image then we immediately launch an other request for th e same image - only one load event should be fired.<br>

	38 Then we do the same again: another load event should be fired.<br>

	39 </div>

	40 <div id="result">FAIL</div>

OLD	NEW