Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1047333002: For the out-of-process NativeRunner, make sure that Start()'s callback always gets called. (Closed)

Created:
5 years, 8 months ago by viettrungluu
Modified:
5 years, 8 months ago
Reviewers:
DaveMoore
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, yzshen+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

For the out-of-process NativeRunner, make sure that Start()'s callback always gets called. R=davemoore@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/bc8d14cb4183dcc07273541544a05650f3d988a5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -5 lines) Patch
M shell/app_child_process_host.h View 2 chunks +10 lines, -2 lines 0 comments Download
M shell/app_child_process_host.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M shell/app_child_process_host_unittest.cc View 2 chunks +42 lines, -1 line 0 comments Download
M shell/application_manager/native_runner.h View 1 chunk +2 lines, -1 line 0 comments Download
M shell/child_process_host.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
viettrungluu
5 years, 8 months ago (2015-03-31 22:08:57 UTC) #1
DaveMoore
lgtm
5 years, 8 months ago (2015-03-31 23:17:44 UTC) #2
viettrungluu
5 years, 8 months ago (2015-03-31 23:40:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bc8d14cb4183dcc07273541544a05650f3d988a5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698