Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Unified Diff: shell/app_child_process_host.cc

Issue 1047333002: For the out-of-process NativeRunner, make sure that Start()'s callback always gets called. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « shell/app_child_process_host.h ('k') | shell/app_child_process_host_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: shell/app_child_process_host.cc
diff --git a/shell/app_child_process_host.cc b/shell/app_child_process_host.cc
index 3f97b5ee1d0349a75a4afd399993768332f9b4e5..6cdcfaa206602704ce6861f6a473316823eb7104 100644
--- a/shell/app_child_process_host.cc
+++ b/shell/app_child_process_host.cc
@@ -51,6 +51,7 @@ void AppChildProcessHost::WillStart() {
base::MessageLoop::current()->message_loop_proxy()));
controller_.Bind(handle.Pass());
+ controller_.set_error_handler(this);
}
void AppChildProcessHost::DidStart(bool success) {
@@ -63,6 +64,10 @@ void AppChildProcessHost::DidStart(bool success) {
}
}
+void AppChildProcessHost::OnConnectionError() {
+ AppCompleted(MOJO_RESULT_UNKNOWN);
+}
+
// Callback for |embedder::CreateChannel()|.
void AppChildProcessHost::DidCreateChannel(
embedder::ChannelInfo* channel_info) {
« no previous file with comments | « shell/app_child_process_host.h ('k') | shell/app_child_process_host_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698