Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 1047253003: Revert of Expose multiline attribute from blink (Closed)

Created:
5 years, 8 months ago by jianli
Modified:
5 years, 8 months ago
CC:
aboxhall, blink-reviews, dglazkov+blink, je_julie(Not used), nektarios
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Expose multiline attribute from blink (patchset #4 id:60001 of https://codereview.chromium.org/1045693002/) Reason for revert: A likely culprit for AutomationApiTest.Mixins failures in many chromium.webkit bots. https://build.chromium.org/p/chromium.webkit/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/522/steps/browser_tests/logs/AutomationApiTest.Mixins Original issue's description: > Expose multiline attribute from blink > > This CL adds a method to expose multiline attr to chromium. > > This CL is starting patch to Get rid of separate TextField and TextArea AX roles > and support a single role TextField with multiline attribute. More CLs will follow this. > > BUG=471152 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192814 TBR=mkwst@chromium.org,aboxhall@chromium.org,dmazzoni@chromium.org,shreeram.k@samsung.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=471152 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192848

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -38 lines) Patch
M Source/modules/accessibility/AXLayoutObject.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/modules/accessibility/AXNodeObject.cpp View 4 chunks +6 lines, -3 lines 0 comments Download
M Source/modules/accessibility/AXObject.h View 2 chunks +1 line, -2 lines 0 comments Download
M Source/modules/accessibility/AXObject.cpp View 8 chunks +9 lines, -18 lines 0 comments Download
M Source/modules/accessibility/InspectorAccessibilityAgent.cpp View 2 chunks +5 lines, -3 lines 0 comments Download
M Source/web/AssertMatchingEnums.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebAXObject.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M public/web/WebAXEnums.h View 1 chunk +0 lines, -1 line 0 comments Download
M public/web/WebAXObject.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
jianli
Created Revert of Expose multiline attribute from blink
5 years, 8 months ago (2015-03-31 19:07:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1047253003/1
5 years, 8 months ago (2015-03-31 19:08:16 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=192848
5 years, 8 months ago (2015-03-31 19:09:02 UTC) #3
jianli
5 years, 8 months ago (2015-03-31 20:49:28 UTC) #4
Message was sent while issue was closed.
The revert fixed the problem.

Powered by Google App Engine
This is Rietveld 408576698