Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1047243003: Update display names for ChromeOS device types. (Closed)

Created:
5 years, 8 months ago by Tim Song
Modified:
5 years, 8 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update display names for ChromeOS device types. Committed: https://crrev.com/81541c3a626b0dfe1c5db4078754992fbbf03d04 Cr-Commit-Position: refs/heads/master@{#323112}

Patch Set 1 #

Total comments: 2

Patch Set 2 : indent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -6 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/chromeos_utils.cc View 1 4 chunks +21 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Tim Song
5 years, 8 months ago (2015-03-31 20:02:33 UTC) #2
xiyuan
lgtm https://codereview.chromium.org/1047243003/diff/1/chrome/browser/chromeos/chromeos_utils.cc File chrome/browser/chromeos/chromeos_utils.cc (right): https://codereview.chromium.org/1047243003/diff/1/chrome/browser/chromeos/chromeos_utils.cc#newcode19 chrome/browser/chromeos/chromeos_utils.cc:19: "monroe", nit: update indent here too?
5 years, 8 months ago (2015-03-31 20:33:51 UTC) #3
Tim Song
https://codereview.chromium.org/1047243003/diff/1/chrome/browser/chromeos/chromeos_utils.cc File chrome/browser/chromeos/chromeos_utils.cc (right): https://codereview.chromium.org/1047243003/diff/1/chrome/browser/chromeos/chromeos_utils.cc#newcode19 chrome/browser/chromeos/chromeos_utils.cc:19: "monroe", On 2015/03/31 20:33:51, xiyuan wrote: > nit: update ...
5 years, 8 months ago (2015-03-31 20:49:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1047243003/20001
5 years, 8 months ago (2015-03-31 20:51:04 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-03-31 21:26:22 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-03-31 21:26:51 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/81541c3a626b0dfe1c5db4078754992fbbf03d04
Cr-Commit-Position: refs/heads/master@{#323112}

Powered by Google App Engine
This is Rietveld 408576698