Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1843)

Unified Diff: chrome/browser/chromeos/chromeos_utils.cc

Issue 1047243003: Update display names for ChromeOS device types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: indent Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/chromeos_strings.grdp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/chromeos_utils.cc
diff --git a/chrome/browser/chromeos/chromeos_utils.cc b/chrome/browser/chromeos/chromeos_utils.cc
index 8a58a0e4f140c01117401dd612835487c2e401d8..c6777e5fd8d95b7ee9b3beab7d896c4e8a0db353 100644
--- a/chrome/browser/chromeos/chromeos_utils.cc
+++ b/chrome/browser/chromeos/chromeos_utils.cc
@@ -15,16 +15,24 @@ namespace {
// List of ChromeOS board names corresponding to Chromebase devices. Googlers
// can find a list of ChromeOS device and board names at http://go/cros-names
-const char* const kChromebaseBoards[] = {
- "monroe",
+const char* const kChromebaseBoards[] = {
+ "monroe",
};
// List of ChromeOS board names corresponding to Chromebox devices. Googlers
// can find a list of ChromeOS device and board names at http://go/cros-names
-const char* const kChromeboxBoards[] = {
- "panther",
- "stumpy",
- "zako",
+const char* const kChromeboxBoards[] = {
+ "panther",
+ "stumpy",
+ "zako",
+ "tricky",
+ "mccloud",
+};
+
+// List of ChromeOS board names corresponding to Chromebit devices. Googlers
+// can find a list of ChromeOS device and board names at http://go/cros-names
+const char* const kChromebitBoards[] = {
+ "veyron_brain",
};
} // namespace
@@ -33,6 +41,7 @@ namespace chrome_device_types {
const char kChromebox[] = "chromebox";
const char kChromebase[] = "chromebase";
+const char kChromebit[] = "chromebit";
const char kChromebook[] = "chromebook";
} // namespace chrome_device_types
@@ -51,6 +60,10 @@ int GetChromeDeviceTypeResourceId() {
if (StartsWithASCII(board, kChromebaseBoards[i], true))
return IDS_CHROMEBASE;
}
+ for (size_t i = 0; i < arraysize(kChromebitBoards); ++i) {
+ if (StartsWithASCII(board, kChromebitBoards[i], true))
+ return IDS_CHROMEBIT;
+ }
return IDS_CHROMEBOOK;
}
@@ -61,6 +74,8 @@ std::string GetChromeDeviceTypeString() {
return chrome_device_types::kChromebox;
case IDS_CHROMEBASE:
return chrome_device_types::kChromebase;
+ case IDS_CHROMEBIT:
+ return chrome_device_types::kChromebit;
default:
NOTREACHED() << "Unknown Chrome device type: " << resource_id;
case IDS_CHROMEBOOK:
« no previous file with comments | « chrome/app/chromeos_strings.grdp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698