Issue 1047173002: [turbofan] Weaken DCHECK to allow tagged numbers in frame state values constants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1047173002: [turbofan] Weaken DCHECK to allow tagged numbers in frame state values constants. (Closed)

Created:
5 years, 8 months ago by Jarin

Modified:
5 years, 8 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

[turbofan] Weaken a DCHECK to allow tagged numbers as double constants in frame states. BUG=chromium:472078 LOG=n R=mstarzinger@chromium.org Committed: https://crrev.com/ad16b35995803accef25da8547280229d16f18e4 Cr-Commit-Position: refs/heads/master@{#27542}

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	src/compiler/code-generator.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 6 (1 generated)

Jarin

Could you take a look, please? There was a CF test for this, but it ...

5 years, 8 months ago (2015-03-31 13:00:18 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1047173002/1

5 years, 8 months ago (2015-03-31 13:45:24 UTC) #4

commit-bot: I haz the power

5 years, 8 months ago (2015-03-31 13:47:04 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/ad16b35995803accef25da8547280229d16f18e4
Cr-Commit-Position: refs/heads/master@{#27542}