Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Side by Side Diff: src/compiler/code-generator.cc

Issue 1047173002: [turbofan] Weaken DCHECK to allow tagged numbers in frame state values constants. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/code-generator.h" 5 #include "src/compiler/code-generator.h"
6 6
7 #include "src/compiler/code-generator-impl.h" 7 #include "src/compiler/code-generator-impl.h"
8 #include "src/compiler/linkage.h" 8 #include "src/compiler/linkage.h"
9 #include "src/compiler/pipeline.h" 9 #include "src/compiler/pipeline.h"
10 10
(...skipping 539 matching lines...) Expand 10 before | Expand all | Expand 10 after
550 Constant constant = converter.ToConstant(op); 550 Constant constant = converter.ToConstant(op);
551 Handle<Object> constant_object; 551 Handle<Object> constant_object;
552 switch (constant.type()) { 552 switch (constant.type()) {
553 case Constant::kInt32: 553 case Constant::kInt32:
554 DCHECK(type == kMachInt32 || type == kMachUint32 || type == kRepBit); 554 DCHECK(type == kMachInt32 || type == kMachUint32 || type == kRepBit);
555 constant_object = 555 constant_object =
556 isolate()->factory()->NewNumberFromInt(constant.ToInt32()); 556 isolate()->factory()->NewNumberFromInt(constant.ToInt32());
557 break; 557 break;
558 case Constant::kFloat64: 558 case Constant::kFloat64:
559 DCHECK(type == kMachFloat64 || type == kMachAnyTagged || 559 DCHECK(type == kMachFloat64 || type == kMachAnyTagged ||
560 type == kRepTagged || type == (kTypeInt32 | kRepTagged) || 560 type == kRepTagged || type == (kTypeNumber | kRepTagged) ||
561 type == (kTypeInt32 | kRepTagged) ||
561 type == (kTypeUint32 | kRepTagged)); 562 type == (kTypeUint32 | kRepTagged));
562 constant_object = isolate()->factory()->NewNumber(constant.ToFloat64()); 563 constant_object = isolate()->factory()->NewNumber(constant.ToFloat64());
563 break; 564 break;
564 case Constant::kHeapObject: 565 case Constant::kHeapObject:
565 DCHECK((type & kRepMask) == kRepTagged); 566 DCHECK((type & kRepMask) == kRepTagged);
566 constant_object = constant.ToHeapObject(); 567 constant_object = constant.ToHeapObject();
567 break; 568 break;
568 default: 569 default:
569 CHECK(false); 570 CHECK(false);
570 } 571 }
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
640 : masm_(gen->masm()), next_(gen->ools_) { 641 : masm_(gen->masm()), next_(gen->ools_) {
641 gen->ools_ = this; 642 gen->ools_ = this;
642 } 643 }
643 644
644 645
645 OutOfLineCode::~OutOfLineCode() {} 646 OutOfLineCode::~OutOfLineCode() {}
646 647
647 } // namespace compiler 648 } // namespace compiler
648 } // namespace internal 649 } // namespace internal
649 } // namespace v8 650 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698