Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(826)

Unified Diff: Source/core/html/track/vtt/VTTParser.h

Issue 104713002: Use the return value to signal success for VTTParser helpers (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Re-add ASSERT in markFutureAndPastNodes. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/track/vtt/VTTCue.cpp ('k') | Source/core/html/track/vtt/VTTParser.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/track/vtt/VTTParser.h
diff --git a/Source/core/html/track/vtt/VTTParser.h b/Source/core/html/track/vtt/VTTParser.h
index c060677640db86ba1252c40eb859bd145a787807..df4e584cae96bfdada76062a346294908d2e74e0 100644
--- a/Source/core/html/track/vtt/VTTParser.h
+++ b/Source/core/html/track/vtt/VTTParser.h
@@ -95,11 +95,11 @@ public:
}
static unsigned collectDigitsToInt(const String& input, unsigned* position, int& number);
static String collectWord(const String&, unsigned*);
- static double collectTimeStamp(const String&, unsigned*);
+ static bool collectTimeStamp(const String&, unsigned*, double& timeStamp);
// Useful functions for parsing percentage settings.
- static float parseFloatPercentageValue(const String&, bool&);
- static FloatPoint parseFloatPercentageValuePair(const String&, char, bool&);
+ static bool parseFloatPercentageValue(const String&, float&);
+ static bool parseFloatPercentageValuePair(const String&, char, FloatPoint&);
// Create the DocumentFragment representation of the WebVTT cue text.
static PassRefPtr<DocumentFragment> createDocumentFragmentFromCueText(Document&, const String&);
« no previous file with comments | « Source/core/html/track/vtt/VTTCue.cpp ('k') | Source/core/html/track/vtt/VTTParser.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698