Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Unified Diff: Source/core/html/track/vtt/VTTCue.cpp

Issue 104713002: Use the return value to signal success for VTTParser helpers (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Re-add ASSERT in markFutureAndPastNodes. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/html/track/vtt/VTTParser.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/track/vtt/VTTCue.cpp
diff --git a/Source/core/html/track/vtt/VTTCue.cpp b/Source/core/html/track/vtt/VTTCue.cpp
index 7006b00981ad87ecf720b28d0141c468e9f2bb13..a0c47155775809e6b61cb9492185f7feca19b96f 100644
--- a/Source/core/html/track/vtt/VTTCue.cpp
+++ b/Source/core/html/track/vtt/VTTCue.cpp
@@ -675,8 +675,9 @@ void VTTCue::markFutureAndPastNodes(ContainerNode* root, double previousTimestam
if (child->nodeName() == timestampTag) {
unsigned position = 0;
String timestamp = child->nodeValue();
- double currentTimestamp = VTTParser::collectTimeStamp(timestamp, &position);
- ASSERT(currentTimestamp != -1);
+ double currentTimestamp;
+ bool check = VTTParser::collectTimeStamp(timestamp, &position, currentTimestamp);
+ ASSERT_UNUSED(check, check);
if (currentTimestamp > movieTime)
isPastNode = false;
« no previous file with comments | « no previous file | Source/core/html/track/vtt/VTTParser.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698