Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1047023002: use == and != to enable handling null/undefined (Closed)

Created:
5 years, 8 months ago by Jennifer Messerly
Modified:
5 years, 8 months ago
Reviewers:
vsm, Jacob
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 : #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1262 lines, -1248 lines) Patch
M lib/runtime/dart/_interceptors.js View 32 chunks +57 lines, -57 lines 0 comments Download
M lib/runtime/dart/_internal.js View 34 chunks +55 lines, -55 lines 0 comments Download
M lib/runtime/dart/_isolate_helper.js View 37 chunks +55 lines, -55 lines 0 comments Download
M lib/runtime/dart/_js_helper.js View 124 chunks +217 lines, -217 lines 0 comments Download
M lib/runtime/dart/_native_typed_data.js View 26 chunks +39 lines, -39 lines 0 comments Download
M lib/runtime/dart/async.js View 102 chunks +195 lines, -195 lines 0 comments Download
M lib/runtime/dart/collection.js View 148 chunks +274 lines, -274 lines 0 comments Download
M lib/runtime/dart/convert.js View 50 chunks +75 lines, -75 lines 0 comments Download
M lib/runtime/dart/core.js View 101 chunks +225 lines, -225 lines 0 comments Download
M lib/runtime/dart/isolate.js View 3 chunks +3 lines, -3 lines 0 comments Download
M lib/runtime/dart/math.js View 7 chunks +9 lines, -9 lines 0 comments Download
M lib/runtime/dart/typed_data.js View 1 chunk +1 line, -1 line 0 comments Download
M lib/runtime/dart_runtime.js View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/src/codegen/js_codegen.dart View 1 2 chunks +19 lines, -5 lines 0 comments Download
M test/codegen/expect/BenchmarkBase.js View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/DeltaBlue.js View 14 chunks +27 lines, -27 lines 0 comments Download
M test/codegen/expect/dir/html_input_d.js View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/server_mode/dir/html_input_d.js View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/server_mode/html_input.html View 1 chunk +5 lines, -5 lines 0 comments Download
M test/codegen/expect/sunflower/sunflower.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Jennifer Messerly
for discussion. Opinions? Jacob and I are thinking this will get us going faster, as ...
5 years, 8 months ago (2015-03-30 21:50:01 UTC) #2
Jacob
lgtm https://codereview.chromium.org/1047023002/diff/60001/lib/src/codegen/js_codegen.dart File lib/src/codegen/js_codegen.dart (right): https://codereview.chromium.org/1047023002/diff/60001/lib/src/codegen/js_codegen.dart#newcode1503 lib/src/codegen/js_codegen.dart:1503: DartType _toJsNumType(DartType t) { _toJsNumType --> _canonicalizeNumTypes
5 years, 8 months ago (2015-03-30 22:44:24 UTC) #6
vsm
lgtm
5 years, 8 months ago (2015-03-30 22:45:01 UTC) #7
Jennifer Messerly
5 years, 8 months ago (2015-03-30 23:01:26 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:80001) manually as
fb0117f308f019d4ffbb09381482d34bdfd7d081 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698