Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1180)

Unified Diff: lib/runtime/dart/isolate.js

Issue 1047023002: use == and != to enable handling null/undefined (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/runtime/dart/core.js ('k') | lib/runtime/dart/math.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/runtime/dart/isolate.js
diff --git a/lib/runtime/dart/isolate.js b/lib/runtime/dart/isolate.js
index 52272a90a6f4126e590f9f07755c9cfa461768bb..9aeb01c09de7035475cc0f31cffd24b2fbd6c78f 100644
--- a/lib/runtime/dart/isolate.js
+++ b/lib/runtime/dart/isolate.js
@@ -40,7 +40,7 @@ var isolate;
static spawnUri(uri, args, message, opts) {
let paused = opts && 'paused' in opts ? opts.paused : false;
let packageRoot = opts && 'packageRoot' in opts ? opts.packageRoot : null;
- if (packageRoot !== null)
+ if (packageRoot != null)
throw new core.UnimplementedError("packageRoot");
try {
if (dart.is(args, core.List$(core.String))) {
@@ -49,7 +49,7 @@ var isolate;
throw new core.ArgumentError(`Args must be a list of Strings ${args}`);
}
}
- } else if (args !== null) {
+ } else if (args != null) {
throw new core.ArgumentError(`Args must be a list of Strings ${args}`);
}
return dart.as(_isolate_helper.IsolateNatives.spawnUri(uri, args, message, paused).then(dart.closureWrap((msg) => new Isolate(dart.as(dart.dindex(msg, 1), SendPort), {pauseCapability: dart.as(dart.dindex(msg, 2), Capability), terminateCapability: dart.as(dart.dindex(msg, 3), Capability)}), "(List<dynamic>) → dynamic")), async.Future$(Isolate));
@@ -62,7 +62,7 @@ var isolate;
pause(resumeCapability) {
if (resumeCapability === void 0)
resumeCapability = null;
- if (resumeCapability === null)
+ if (resumeCapability == null)
resumeCapability = new Capability();
this[_pause](resumeCapability);
return resumeCapability;
« no previous file with comments | « lib/runtime/dart/core.js ('k') | lib/runtime/dart/math.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698