Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1046883002: Use multiline attribute to check for IA2_STATE_MULTILINE. (Closed)

Created:
5 years, 8 months ago by shreeramk
Modified:
5 years, 8 months ago
Reviewers:
dmazzoni, aboxhall
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, je_julie(Not used), plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use multiline attribute to check for IA2_STATE_MULTILINE. This CL use the multiline attribute only to see if it's multiline or not and Changes Chromium to treat TextField and TextArea identically. BUG=471152 Committed: https://crrev.com/7e576157bba19b8918f0ad2e3a43d0171a675155 Cr-Commit-Position: refs/heads/master@{#324189} Committed: https://crrev.com/01ccdaebd88c8b14aab2e41a0a80de278fd71b99 Cr-Commit-Position: refs/heads/master@{#324212}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : updating #

Patch Set 4 : updating expectation on win #

Patch Set 5 : fixing bug on mac #

Patch Set 6 : Fixing automation test - mixins #

Patch Set 7 : #

Patch Set 8 : Fixing automation test unit #

Total comments: 1

Patch Set 9 : fixing space nit #

Patch Set 10 : Removing textarea #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -55 lines) Patch
M chrome/browser/extensions/api/automation/automation_apitest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/chrome_extension_externs.js View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/api/automation.idl View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/automation/automation_node.js View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/automation/tests/tabs/mixins.js View 1 2 3 4 5 6 3 chunks +7 lines, -8 lines 0 comments Download
M chrome/test/data/extensions/api_test/automation/tests/unit/test.js View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility.cc View 2 chunks +1 line, -3 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_android.cc View 5 chunks +2 lines, -6 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_cocoa.mm View 1 2 3 4 5 6 7 8 5 chunks +7 lines, -7 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_win.cc View 1 2 1 chunk +4 lines, -7 lines 0 comments Download
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 1 2 3 chunks +3 lines, -6 lines 0 comments Download
M content/renderer/accessibility/blink_ax_enum_conversion.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M content/renderer/accessibility/blink_ax_tree_source.cc View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M content/shell/renderer/test_runner/web_ax_object_proxy.cc View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -2 lines 0 comments Download
M content/test/data/accessibility/html/textarea.html View 1 2 chunks +1 line, -1 line 0 comments Download
M content/test/data/accessibility/html/textarea-expected-mac.txt View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M content/test/data/accessibility/html/textarea-expected-win.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ui/accessibility/ax_enums.idl View 1 2 2 chunks +1 line, -1 line 0 comments Download
M ui/accessibility/platform/ax_platform_node_mac.mm View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 16 (6 generated)
dmazzoni
https://codereview.chromium.org/1046883002/diff/1/ui/accessibility/ax_enums.idl File ui/accessibility/ax_enums.idl (right): https://codereview.chromium.org/1046883002/diff/1/ui/accessibility/ax_enums.idl#newcode10 ui/accessibility/ax_enums.idl:10: // chrome/common/extensions/api/automation.idl. Don't forget to modify automation.idl too
5 years, 8 months ago (2015-03-30 13:40:16 UTC) #2
shreeramk
@Dominic: PTAL. @Alice: Owner review for automation tests. Thanks!
5 years, 8 months ago (2015-04-07 10:40:49 UTC) #4
dmazzoni
lgtm Nice job! https://codereview.chromium.org/1046883002/diff/140001/content/browser/accessibility/browser_accessibility_cocoa.mm File content/browser/accessibility/browser_accessibility_cocoa.mm (right): https://codereview.chromium.org/1046883002/diff/140001/content/browser/accessibility/browser_accessibility_cocoa.mm#newcode586 content/browser/accessibility/browser_accessibility_cocoa.mm:586: browserAccessibility_->HasState(ui::AX_STATE_MULTILINE)) { nit: indent 4 spaces ...
5 years, 8 months ago (2015-04-07 16:12:34 UTC) #5
aboxhall
lgtm for automation changes. Agreed, nice job!
5 years, 8 months ago (2015-04-07 17:08:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1046883002/160001
5 years, 8 months ago (2015-04-08 03:06:43 UTC) #9
commit-bot: I haz the power
Committed patchset #9 (id:160001)
5 years, 8 months ago (2015-04-08 05:59:24 UTC) #10
commit-bot: I haz the power
Patchset 9 (id:??) landed as https://crrev.com/7e576157bba19b8918f0ad2e3a43d0171a675155 Cr-Commit-Position: refs/heads/master@{#324189}
5 years, 8 months ago (2015-04-08 06:00:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1046883002/180001
5 years, 8 months ago (2015-04-08 10:39:26 UTC) #14
commit-bot: I haz the power
Committed patchset #10 (id:180001)
5 years, 8 months ago (2015-04-08 11:18:17 UTC) #15
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 11:19:13 UTC) #16
Message was sent while issue was closed. 
Patchset 10 (id:??) landed as
https://crrev.com/01ccdaebd88c8b14aab2e41a0a80de278fd71b99
Cr-Commit-Position: refs/heads/master@{#324212}

Powered by Google App Engine
This is Rietveld 408576698