content/browser/accessibility/browser_accessibility.cc - Issue 1046883002: Use multiline attribute to check for IA2_STATE_MULTILINE.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility.cc

Issue 1046883002: Use multiline attribute to check for IA2_STATE_MULTILINE. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removing textarea Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/extensions/api_test/automation/tests/unit/test.js ('k') | content/browser/accessibility/browser_accessibility_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/browser_accessibility.cc

diff --git a/content/browser/accessibility/browser_accessibility.cc b/content/browser/accessibility/browser_accessibility.cc

index 7a8c56020e5dcd761f5b3378e801c046a8a272a0..16a8ed2147b8f909f96620eee26d39a6d421c293 100644

--- a/content/browser/accessibility/browser_accessibility.cc

+++ b/content/browser/accessibility/browser_accessibility.cc

@@ -52,7 +52,6 @@ bool BrowserAccessibility::PlatformIsLeaf() const {

case ui::AX_ROLE_LINE_BREAK:

case ui::AX_ROLE_SLIDER:

case ui::AX_ROLE_STATIC_TEXT:

- case ui::AX_ROLE_TEXT_AREA:

case ui::AX_ROLE_TEXT_FIELD:

return true;

default:

@@ -702,8 +701,7 @@ bool BrowserAccessibility::IsEditableText() const {

// or contenteditable. We also check for editable text roles to cover

// another element that has role=textbox set on it.

return (!HasState(ui::AX_STATE_READ_ONLY) ||

- GetRole() == ui::AX_ROLE_TEXT_FIELD ||

- GetRole() == ui::AX_ROLE_TEXT_AREA);

+ GetRole() == ui::AX_ROLE_TEXT_FIELD);

}

bool BrowserAccessibility::IsWebAreaForPresentationalIframe() const {