Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 104683005: Ignore pylint blacklist on Windows too (Closed)

Created:
7 years ago by scottmg
Modified:
7 years ago
Reviewers:
Nico
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Ignore pylint blacklist on Windows too I'd been cursing pylint on every dcommit for the last year or so and then doing --bypass-hooks. This seems an improvement. R=thakis@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1806

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M PRESUBMIT.py View 1 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
scottmg
7 years ago (2013-12-04 17:02:42 UTC) #1
Nico
lgtm :-D
7 years ago (2013-12-04 17:18:28 UTC) #2
scottmg
7 years ago (2013-12-04 17:25:17 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r1806 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698