Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Side by Side Diff: PRESUBMIT.py

Issue 104683005: Ignore pylint blacklist on Windows too (Closed) Base URL: http://gyp.googlecode.com/svn/trunk
Patch Set: . Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 Google Inc. All rights reserved. 1 # Copyright (c) 2012 Google Inc. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 5
6 """Top-level presubmit script for GYP. 6 """Top-level presubmit script for GYP.
7 7
8 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 8 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
9 for more details about the presubmit API built into gcl. 9 for more details about the presubmit API built into gcl.
10 """ 10 """
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
90 'year': years_re, 90 'year': years_re,
91 } 91 }
92 92
93 report.extend(input_api.canned_checks.PanProjectChecks( 93 report.extend(input_api.canned_checks.PanProjectChecks(
94 input_api, output_api, license_header=license)) 94 input_api, output_api, license_header=license))
95 report.extend(input_api.canned_checks.CheckTreeIsOpen( 95 report.extend(input_api.canned_checks.CheckTreeIsOpen(
96 input_api, output_api, 96 input_api, output_api,
97 'http://gyp-status.appspot.com/status', 97 'http://gyp-status.appspot.com/status',
98 'http://gyp-status.appspot.com/current')) 98 'http://gyp-status.appspot.com/current'))
99 99
100 import os
100 import sys 101 import sys
101 old_sys_path = sys.path 102 old_sys_path = sys.path
102 try: 103 try:
103 sys.path = ['pylib', 'test/lib'] + sys.path 104 sys.path = ['pylib', 'test/lib'] + sys.path
105 blacklist = PYLINT_BLACKLIST
106 if sys.platform == 'win32':
107 blacklist = [os.path.normpath(x).replace('\\', '\\\\')
108 for x in PYLINT_BLACKLIST]
104 report.extend(input_api.canned_checks.RunPylint( 109 report.extend(input_api.canned_checks.RunPylint(
105 input_api, 110 input_api,
106 output_api, 111 output_api,
107 black_list=PYLINT_BLACKLIST, 112 black_list=blacklist,
108 disabled_warnings=PYLINT_DISABLED_WARNINGS)) 113 disabled_warnings=PYLINT_DISABLED_WARNINGS))
109 finally: 114 finally:
110 sys.path = old_sys_path 115 sys.path = old_sys_path
111 return report 116 return report
112 117
113 118
114 def GetPreferredTrySlaves(): 119 def GetPreferredTrySlaves():
115 return ['gyp-win32', 'gyp-win64', 'gyp-linux', 'gyp-mac', 'gyp-android'] 120 return ['gyp-win32', 'gyp-win64', 'gyp-linux', 'gyp-mac', 'gyp-android']
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698