Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 1045943002: Disable still-flaky test TaskManagerBrowserTest.WebWorkerJSHeapMemory. (Closed)

Created:
5 years, 8 months ago by ncarter (slow)
Modified:
5 years, 8 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable still-flaky test TaskManagerBrowserTest.WebWorkerJSHeapMemory. This test is inherently flaky because it relies on a preset timeout period. It needs to be rewritten to use something that works like task_manager::browsertest_util::WaitForTaskManagerRows, i.e., by waiting for taskmanager changes until the condition is satisfied. TBR=thakis@chromium.org BUG=259368 Committed: https://crrev.com/c0c89fde409f090d0097a385611eff711b22577e Cr-Commit-Position: refs/heads/master@{#322862}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/task_manager/task_manager_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1045943002/1
5 years, 8 months ago (2015-03-30 19:56:07 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-03-30 20:55:31 UTC) #4
commit-bot: I haz the power
5 years, 8 months ago (2015-03-30 20:56:22 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c0c89fde409f090d0097a385611eff711b22577e
Cr-Commit-Position: refs/heads/master@{#322862}

Powered by Google App Engine
This is Rietveld 408576698