Issue 1045893004: Remove is_win/OS_WIN checks in shell code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1045893004: Remove is_win/OS_WIN checks in shell code (Closed)

Created:
5 years, 8 months ago by jamesr

Modified:
5 years, 8 months ago

Reviewers:
viettrungluu

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, yzshen+watch_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Remove is_win/OS_WIN checks in shell code We only develop and test mojo_shell on Android and Linux so checking for windows or posix is not useful since it's either always false (is_win) or always true (is_posix). R=viettrungluu@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/66db2325f2fa10e123835913ae94bb3bac03395e

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -56 lines)			Patch
M	shell/BUILD.gn	View	4 chunks	+1 line, -27 lines	0 comments	Download
M	shell/application_manager/local_fetcher.cc	View	1 chunk	+1 line, -7 lines	0 comments	Download
M	shell/child_process_host.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	shell/command_line_util.cc	View	1 chunk	+1 line, -7 lines	0 comments	Download
M	shell/domain_socket/net_errors.cc	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	shell/filename_util.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

jamesr

5 years, 8 months ago (2015-04-02 19:56:31 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
66db2325f2fa10e123835913ae94bb3bac03395e (presubmit successful).