Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Unified Diff: shell/BUILD.gn

Issue 1045893004: Remove is_win/OS_WIN checks in shell code (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | shell/application_manager/local_fetcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: shell/BUILD.gn
diff --git a/shell/BUILD.gn b/shell/BUILD.gn
index e83e9e4bc4ecc0a1cf37ce3e982fb73ce9d92222..a66f9f4a56c98a07a2d8d94e828245cfcfe89c8d 100644
--- a/shell/BUILD.gn
+++ b/shell/BUILD.gn
@@ -17,14 +17,11 @@ group("shell") {
testonly = true
deps = [
+ ":mojo_launcher",
":mojo_shell",
":tests",
]
- if (!is_win) {
- deps += [ ":mojo_launcher" ]
- }
-
if (is_android) {
deps += [
":mojo_shell_apk",
@@ -195,10 +192,6 @@ source_set("lib") {
":switches",
]
- if (is_win) {
- deps -= [ "//shell/domain_socket" ]
- }
-
if (is_android) {
sources += [
"android/android_handler.cc",
@@ -408,10 +401,6 @@ source_set("external_application_registrar_connection") {
"//shell/domain_socket",
"//url",
]
-
- if (is_win) {
- deps -= [ "//shell/domain_socket" ]
- }
}
# GYP version: mojo/mojo.gyp:mojo_shell_tests
@@ -505,21 +494,6 @@ test("external_application_unittests") {
"//shell/domain_socket",
"//shell/domain_socket:tests",
]
-
- if (is_win) {
- sources -= [
- "external_application_listener_unittest.cc",
- "incoming_connection_listener_unittest.cc",
- ]
-
- deps -= [
- ":lib",
- ":external_application_registrar_connection",
- ":external_application_registrar_bindings",
- "//shell/domain_socket",
- "//shell/domain_socket:tests",
- ]
- }
}
embed_file("embed_pingable") {
« no previous file with comments | « no previous file | shell/application_manager/local_fetcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698