Issue 1045753003: Fix logging test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1045753003: Fix logging test (Closed)

Created:
5 years, 8 months ago by vsm

Modified:
5 years, 8 months ago

Reviewers:
Leaf, Jennifer Messerly

CC:
dev-compiler+reviews_dartlang.org

Base URL:
https://github.com/dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix logging test Just updating the broken test. The dart_runtime.dart type rules are still out of date. R=leafp@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/c43d2d7e1c71f969c4e24b3183901455d078d0c1

Patch Set 1 #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -7 lines)			Patch
	M	lib/runtime/dart_logging_runtime.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	test/runtime/dart_logging_runtime_test.dart	View		2 chunks	+7 lines, -5 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Jennifer Messerly

the fix looks good, but shouldn't we be running this from all_tests, so it's picked ...

5 years, 8 months ago (2015-03-30 14:46:02 UTC) #4

vsm

Committed patchset #1 (id:1) manually as c43d2d7e1c71f969c4e24b3183901455d078d0c1 (presubmit successful).

5 years, 8 months ago (2015-03-30 23:03:59 UTC) #6

vsm

5 years, 8 months ago (2015-03-30 23:07:43 UTC) #7

Message was sent while issue was closed.

On 2015/03/30 14:46:02, John Messerly wrote:
> the fix looks good, but shouldn't we be running this from all_tests, so it's
> picked up by travis/test.sh ?

Yes, though I'd prefer fixing type rules before adding them back in.  Issue
filed:

https://github.com/dart-lang/dev_compiler/issues/117

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages