lib/runtime/dart_logging_runtime.dart - Issue 1045753003: Fix logging test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/runtime/dart_logging_runtime.dart

Issue 1045753003: Fix logging test (Closed) Base URL: https://github.com/dart-lang/dev_compiler.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/runtime/dart_logging_runtime.dart

diff --git a/lib/runtime/dart_logging_runtime.dart b/lib/runtime/dart_logging_runtime.dart

index 1f76393e47130fe5c6e2dc94833d77eeac3ad73a..ac5273a6cabd73f08e896acf76560b0ba6bb5636 100644

--- a/lib/runtime/dart_logging_runtime.dart

+++ b/lib/runtime/dart_logging_runtime.dart

@@ -49,8 +49,8 @@ CastRecord _lookupInCache(Type runtimeType, Type staticType) {

var _successCache = <Type, Set<Type>>{};

-dynamic cast(dynamic obj, Type fromType, Type staticType, String kind,

- String key, bool dartIs, bool isGround) {

+dynamic cast(dynamic obj, Type fromType, Type staticType, [String kind,

+ String key, bool dartIs, bool isGround]) {

var runtimeType = obj.runtimeType;

// Short-circuit uninteresting cases.

if (_skipSuccess && _successCache.containsKey(staticType)) {

« no previous file with comments | « no previous file | test/runtime/dart_logging_runtime_test.dart » ('j') | no next file with comments »