CpuProfiler: public API for deopt info in cpu profiler.

include/v8-profiler.h

Index: include/v8-profiler.h
diff --git a/include/v8-profiler.h b/include/v8-profiler.h
index f9439c2e629445c610b226438a21f82b2687b8de..43151b5b0f2e6d13b47f8dabaafa92a617adab74 100644
--- a/include/v8-profiler.h
+++ b/include/v8-profiler.h
@@ -5,6 +5,7 @@
 #ifndef V8_V8_PROFILER_H_
 #define V8_V8_PROFILER_H_
 
+#include <vector>
 #include "v8.h"
 
 /**
@@ -17,6 +18,17 @@ struct HeapStatsUpdate;
 
 typedef uint32_t SnapshotObjectId;
 
+
+struct V8_EXPORT CpuProfileDeoptInfo {
+  struct Frame {
+    int script_id;
+    unsigned int position;

[yurys, 2015/03/30 20:33:15]

unsigned int -> unsigned

[Sven Panne, 2015/03/31 06:27:09]

I think that size_t is the right type here, isn't it? It might be the case that
we have wrong types internally, but at least we should get things right on the
external API.

[yurys, 2015/03/31 06:53:49]

Agree, size_t would be even better.

[loislo, 2015/03/31 08:22:51]

done

+  };
+  const char* deopt_reason;

[Sven Panne, 2015/03/31 06:27:09]

Add a comment about ownership here, naked pointer are always a bit vague...

[loislo, 2015/03/31 08:22:51]

done

+  std::vector<Frame> stack;
+};
+
+
 /**
  * CpuProfileNode represents a node in a call graph.
  */
@@ -85,6 +97,9 @@ class V8_EXPORT CpuProfileNode {
   /** Retrieves a child node by index. */
   const CpuProfileNode* GetChild(int index) const;
 
+  /** Retrieves deopt infos for the node. */
+  const std::vector<CpuProfileDeoptInfo>& GetDeoptInfos() const;
+
   static const int kNoLineNumberInfo = Message::kNoLineNumberInfo;
   static const int kNoColumnNumberInfo = Message::kNoColumnInfo;
 };